Commit 821f1b21 authored by Roopa Prabhu's avatar Roopa Prabhu Committed by David S. Miller
Browse files

bridge: add new BR_NEIGH_SUPPRESS port flag to suppress arp and nd flood 

This patch adds a new bridge port flag BR_NEIGH_SUPPRESS to
suppress arp and nd flood on bridge ports. It implements
rfc7432, section 10.
https://tools.ietf.org/html/rfc7432#section-10


for ethernet VPN deployments. It is similar to the existing
BR_PROXYARP* flags but has a few semantic differences to conform
to EVPN standard. Unlike the existing flags, this new flag suppresses
flood of all neigh discovery packets (arp and nd) to tunnel ports.
Supports both vlan filtering and non-vlan filtering bridges.

In case of EVPN, it is mainly used to avoid flooding
of arp and nd packets to tunnel ports like vxlan.

This patch adds netlink and sysfs support to set this bridge port
flag.

Signed-off-by: default avatarRoopa Prabhu <roopa@cumulusnetworks.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 951f788a

include/linux/if_bridge.h

+1 −0
Original line number Diff line number Diff line
@@ -49,6 +49,7 @@ struct br_ip_list { 
#define BR_MULTICAST_TO_UNICAST	BIT(12)

#define BR_VLAN_TUNNEL		BIT(13)

#define BR_BCAST_FLOOD		BIT(14)

#define BR_NEIGH_SUPPRESS	BIT(15)



#define BR_DEFAULT_AGEING_TIME	(300 * HZ)

include/uapi/linux/if_link.h

+1 −0
Original line number Diff line number Diff line
@@ -327,6 +327,7 @@ enum { 
	IFLA_BRPORT_VLAN_TUNNEL,

	IFLA_BRPORT_BCAST_FLOOD,

	IFLA_BRPORT_GROUP_FWD_MASK,

	IFLA_BRPORT_NEIGH_SUPPRESS,

	__IFLA_BRPORT_MAX

};

#define IFLA_BRPORT_MAX (__IFLA_BRPORT_MAX - 1)

net/bridge/Makefile

+1 −1
Original line number Diff line number Diff line
@@ -7,7 +7,7 @@ obj-$(CONFIG_BRIDGE) += bridge.o 
bridge-y	:= br.o br_device.o br_fdb.o br_forward.o br_if.o br_input.o \

			br_ioctl.o br_stp.o br_stp_bpdu.o \

			br_stp_if.o br_stp_timer.o br_netlink.o \

			br_netlink_tunnel.o

			br_netlink_tunnel.o br_arp_nd_proxy.o



bridge-$(CONFIG_SYSFS) += br_sysfs_if.o br_sysfs_br.o

net/bridge/br_arp_nd_proxy.c

0 → 100644
+32 −0
Original line number Diff line number Diff line 
/*

 *  Handle bridge arp/nd proxy/suppress

 *

 *  Copyright (C) 2017 Cumulus Networks

 *  Copyright (c) 2017 Roopa Prabhu <roopa@cumulusnetworks.com>

 *

 *  Authors:

 *	Roopa Prabhu <roopa@cumulusnetworks.com>

 *

 *  This program is free software; you can redistribute it and/or

 *  modify it under the terms of the GNU General Public License

 *  as published by the Free Software Foundation; either version

 *  2 of the License, or (at your option) any later version.

 */



#include <linux/kernel.h>

#include "br_private.h"



void br_recalculate_neigh_suppress_enabled(struct net_bridge *br)

{

	struct net_bridge_port *p;

	bool neigh_suppress = false;



	list_for_each_entry(p, &br->port_list, list) {

		if (p->flags & BR_NEIGH_SUPPRESS) {

			neigh_suppress = true;

			break;

		}

	}



	br->neigh_suppress_enabled = neigh_suppress;

}

net/bridge/br_forward.c

+1 −1
Original line number Diff line number Diff line
@@ -204,7 +204,7 @@ void br_flood(struct net_bridge *br, struct sk_buff *skb, 
		/* Do not flood to ports that enable proxy ARP */

		if (p->flags & BR_PROXYARP)

			continue;

		if ((p->flags & BR_PROXYARP_WIFI) &&

		if ((p->flags & (BR_PROXYARP_WIFI | BR_NEIGH_SUPPRESS)) &&

		    BR_INPUT_SKB_CB(skb)->proxyarp_replied)

			continue;

CRA Git | Maintained and supported by SUSTech CRA and CCSE