powerpc/mm/slice: Move slice_mask struct definition to slice.c (82185222) · Commits · 戴 / test

This structure definition need not be in a header since this is used only by slice.c file. So move it to slice.c. This also allow us to use SLICE_NUM_HIGH instead of 64. I also switch the low_slices type to u64 from u16. This doesn't have an impact on size of struct due to padding added with u16 type. This helps in using bitmap printing function for printing slice mask. Signed-off-by:

Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com> Signed-off-by:

Michael Ellerman <mpe@ellerman.id.au>

arch/powerpc/include/asm/page_64.h

+0 −11

Original line number	Diff line number	Diff line
		@@ -99,17 +99,6 @@ extern u64 ppc64_pft_size;
		#define GET_HIGH_SLICE_INDEX(addr) ((addr) >> SLICE_HIGH_SHIFT)

		#ifndef __ASSEMBLY__
		/*
		* One bit per slice. We have lower slices which cover 256MB segments
		* upto 4G range. That gets us 16 low slices. For the rest we track slices
		* in 1TB size.
		* 64 below is actually SLICE_NUM_HIGH to fixup complie errros
		*/
		struct slice_mask {
		u16 low_slices;
		DECLARE_BITMAP(high_slices, 64);
		};

		struct mm_struct;

		extern unsigned long slice_get_unmapped_area(unsigned long addr,

arch/powerpc/mm/slice.c

+9 −1

Original line number	Diff line number	Diff line
		@@ -37,7 +37,15 @@
		#include <asm/hugetlb.h>

		static DEFINE_SPINLOCK(slice_convert_lock);

		/*
		* One bit per slice. We have lower slices which cover 256MB segments
		* upto 4G range. That gets us 16 low slices. For the rest we track slices
		* in 1TB size.
		*/
		struct slice_mask {
		u64 low_slices;
		DECLARE_BITMAP(high_slices, SLICE_NUM_HIGH);
		};

		#ifdef DEBUG
		int _slice_debug = 1;

Admin message