Commit 820ec411 authored May 04, 2018 by Sebastian Andrzej Siewior Committed by David S. Miller Jun 05, 2018

alim15x3: move irq-restore before pci_dev_put()



init_chipset_ali15x3() initializes the chipset during init with disabled
interrupts. There is no need to keep the interrupts disabled during
pci_dev_put().
Move the irq-restore before pci_dev_put() is invoked.

Side note: The same init is performed in
drivers/ata/pata_ali.c::ali_init_chipset() without disabled interrupts.
It looks that the same hardware is supported in the ATA land. Would it
make sense to remove this driver since it is supported in the other
subsystem?

Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Acked-by: David S. Miller <davem@davemloft.net>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 5037be16

drivers/ide/alim15x3.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -323,9 +323,9 @@ out:

		pci_write_config_byte(dev, 0x53, tmpbyte);
		}
		local_irq_restore(flags);
		pci_dev_put(north);
		pci_dev_put(isa_dev);
		local_irq_restore(flags);
		return 0;
		}

Admin message