pcmcia: Remove typedef tuple_flags (820dc846) · Commits · 戴 / test

The Linux kernel coding style guidelines suggest not using typedefs for structure types. This patch gets rid of the typedef for tuple_flags. The following Coccinelle semantic patch makes the transformation. @tn@ identifier i; type td; @@ -typedef struct i { ... } -td ; @@ type tn.td; identifier tn.i; @@ -td + struct i Signed-off-by:

Himangi Saraogi <himangi774@gmail.com> Acked-by:

Julia Lawall <julia.lawall@lip6.fr> Signed-off-by:

Dominik Brodowski <linux@dominikbrodowski.net>

drivers/pcmcia/cistpl.c

+6 −6

Original line number	Diff line number	Diff line
		@@ -434,17 +434,17 @@ int pcmcia_replace_cis(struct pcmcia_socket *s,

		/* The high-level CIS tuple services */

		typedef struct tuple_flags {
		struct tuple_flags {
		u_int link_space:4;
		u_int has_link:1;
		u_int mfc_fn:3;
		u_int space:4;
		} tuple_flags;
		};

		#define LINK_SPACE(f) (((tuple_flags *)(&(f)))->link_space)
		#define HAS_LINK(f) (((tuple_flags *)(&(f)))->has_link)
		#define MFC_FN(f) (((tuple_flags *)(&(f)))->mfc_fn)
		#define SPACE(f) (((tuple_flags *)(&(f)))->space)
		#define LINK_SPACE(f) (((struct tuple_flags *)(&(f)))->link_space)
		#define HAS_LINK(f) (((struct tuple_flags *)(&(f)))->has_link)
		#define MFC_FN(f) (((struct tuple_flags *)(&(f)))->mfc_fn)
		#define SPACE(f) (((struct tuple_flags *)(&(f)))->space)

		int pccard_get_first_tuple(struct pcmcia_socket *s, unsigned int function,
		tuple_t *tuple)

Admin message