Commit 8201e207 authored Jul 24, 2008 by Andrew Vasquez Committed by James Bottomley Jul 26, 2008

[SCSI] qla2xxx: Issue proper ISP callbacks during stop-firmware.



As the original code would incorrectly call the non-ISP24xx/25xx
callbacks during recovery, a stop-firmware failure could result
in improper bit-banging of the RISC and in some cases manifest in
a NMI-watchdog trigger due to the RISC not coming out of its
reset state.

Signed-off-by: Andrew Vasquez <andrew.vasquez@qlogic.com>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>

parent 3d164fb0

drivers/scsi/qla2xxx/qla_init.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -4038,8 +4038,8 @@ qla2x00_try_to_stop_firmware(scsi_qla_host_t *ha)
		ret = qla2x00_stop_firmware(ha);
		for (retries = 5; ret != QLA_SUCCESS && ret != QLA_FUNCTION_TIMEOUT &&
		retries ; retries--) {
		qla2x00_reset_chip(ha);
		if (qla2x00_chip_diag(ha) != QLA_SUCCESS)
		ha->isp_ops->reset_chip(ha);
		if (ha->isp_ops->chip_diag(ha) != QLA_SUCCESS)
		continue;
		if (qla2x00_setup_chip(ha) != QLA_SUCCESS)
		continue;

Admin message