Commit 81ca627a authored Oct 14, 2019 by Tejun Heo Committed by Jens Axboe May 14, 2020

iocost: don't let vrate run wild while there's no saturation signal



When the QoS targets are met and nothing is being throttled, there's
no way to tell how saturated the underlying device is - it could be
almost entirely idle, at the cusp of saturation or anywhere inbetween.
Given that there's no information, it's best to keep vrate as-is in
this state.  Before 7cd806a9 ("iocost: improve nr_lagging
handling"), this was the case - if the device isn't missing QoS
targets and nothing is being throttled, busy_level was reset to zero.

While fixing nr_lagging handling, 7cd806a9 ("iocost: improve
nr_lagging handling") broke this.  Now, while the device is hitting
QoS targets and nothing is being throttled, vrate keeps getting
adjusted according to the existing busy_level.

This led to vrate keeping climing till it hits max when there's an IO
issuer with limited request concurrency if the vrate started low.
vrate starts getting adjusted upwards until the issuer can issue IOs
w/o being throttled.  From then on, QoS targets keeps getting met and
nothing on the system needs throttling and vrate keeps getting
increased due to the existing busy_level.

This patch makes the following changes to the busy_level logic.

* Reset busy_level if nr_shortages is zero to avoid the above
  scenario.

* Make non-zero nr_lagging block lowering nr_level but still clear
  positive busy_level if there's clear non-saturation signal - QoS
  targets are met and nr_shortages is non-zero.  nr_lagging's role is
  preventing adjusting vrate upwards while there are long-running
  commands and it shouldn't keep busy_level positive while there's
  clear non-saturation signal.

* Restructure code for clarity and add comments.

Signed-off-by: Tejun Heo <tj@kernel.org>
Reported-by: Andy Newell <newella@fb.com>
Fixes: 7cd806a9 ("iocost: improve nr_lagging handling")
Signed-off-by: Jens Axboe <axboe@kernel.dk>

parent 71ac860a

block/blk-iocost.c

+24 −4

Original line number	Diff line number	Diff line
		@@ -1539,19 +1539,39 @@ skip_surplus_transfers:
		if (rq_wait_pct > RQ_WAIT_BUSY_PCT \|\|
		missed_ppm[READ] > ppm_rthr \|\|
		missed_ppm[WRITE] > ppm_wthr) {
		/* clearly missing QoS targets, slow down vrate */
		ioc->busy_level = max(ioc->busy_level, 0);
		ioc->busy_level++;
		} else if (rq_wait_pct <= RQ_WAIT_BUSY_PCT * UNBUSY_THR_PCT / 100 &&
		missed_ppm[READ] <= ppm_rthr * UNBUSY_THR_PCT / 100 &&
		missed_ppm[WRITE] <= ppm_wthr * UNBUSY_THR_PCT / 100) {
		/* take action iff there is contention */
		if (nr_shortages && !nr_lagging) {
		/* QoS targets are being met with >25% margin */
		if (nr_shortages) {
		/*
		* We're throttling while the device has spare
		* capacity. If vrate was being slowed down, stop.
		*/
		ioc->busy_level = min(ioc->busy_level, 0);
		/* redistribute surpluses first */
		if (!nr_surpluses)

		/*
		* If there are IOs spanning multiple periods, wait
		* them out before pushing the device harder. If
		* there are surpluses, let redistribution work it
		* out first.
		*/
		if (!nr_lagging && !nr_surpluses)
		ioc->busy_level--;
		} else {
		/*
		* Nobody is being throttled and the users aren't
		* issuing enough IOs to saturate the device. We
		* simply don't know how close the device is to
		* saturation. Coast.
		*/
		ioc->busy_level = 0;
		}
		} else {
		/* inside the hysterisis margin, we're good */
		ioc->busy_level = 0;
		}

Admin message