Commit 81bc8c03 authored by YueHaibing's avatar YueHaibing Committed by Enric Balletbo i Serra
Browse files

platform/chrome: cros_ec: Make some symbols static 



Fix sparse warning:

drivers/platform/chrome/cros_ec_debugfs.c:256:30: warning: symbol 'cros_ec_console_log_fops' was not declared. Should it be static?
drivers/platform/chrome/cros_ec_debugfs.c:265:30: warning: symbol 'cros_ec_pdinfo_fops' was not declared. Should it be static?
drivers/platform/chrome/cros_ec_lightbar.c:550:24: warning: symbol 'cros_ec_lightbar_attr_group' was not declared. Should it be static?
drivers/platform/chrome/cros_ec_sysfs.c:338:24: warning: symbol 'cros_ec_attr_group' was not declared. Should it be static?
drivers/platform/chrome/cros_ec_vbc.c:104:24: warning: symbol 'cros_ec_vbc_attr_group' was not declared. Should it be static?
drivers/platform/chrome/cros_ec_lpc.c:408:25: warning: symbol 'cros_ec_lpc_pm_ops' was not declared. Should it be static?

Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarYueHaibing <yuehaibing@huawei.com>
Reviewed-by: default avatarBenson Leung <bleung@chromium.org>
Signed-off-by: default avatarEnric Balletbo i Serra <enric.balletbo@collabora.com>
parent 79e3f1d3

drivers/platform/chrome/cros_ec_debugfs.c

+2 −2
Original line number Diff line number Diff line
@@ -241,7 +241,7 @@ static ssize_t cros_ec_pdinfo_read(struct file *file, 
				       read_buf, p - read_buf);

}



const struct file_operations cros_ec_console_log_fops = {

static const struct file_operations cros_ec_console_log_fops = {

	.owner = THIS_MODULE,

	.open = cros_ec_console_log_open,

	.read = cros_ec_console_log_read,
@@ -250,7 +250,7 @@ const struct file_operations cros_ec_console_log_fops = { 
	.release = cros_ec_console_log_release,

};



const struct file_operations cros_ec_pdinfo_fops = {

static const struct file_operations cros_ec_pdinfo_fops = {

	.owner = THIS_MODULE,

	.open = simple_open,

	.read = cros_ec_pdinfo_read,

drivers/platform/chrome/cros_ec_lightbar.c

+1 −1
Original line number Diff line number Diff line
@@ -547,7 +547,7 @@ static struct attribute *__lb_cmds_attrs[] = { 
	NULL,

};



struct attribute_group cros_ec_lightbar_attr_group = {

static struct attribute_group cros_ec_lightbar_attr_group = {

	.name = "lightbar",

	.attrs = __lb_cmds_attrs,

};

drivers/platform/chrome/cros_ec_lpc.c

+1 −1
Original line number Diff line number Diff line
@@ -405,7 +405,7 @@ static int cros_ec_lpc_resume(struct device *dev) 
}

#endif



const struct dev_pm_ops cros_ec_lpc_pm_ops = {

static const struct dev_pm_ops cros_ec_lpc_pm_ops = {

	SET_LATE_SYSTEM_SLEEP_PM_OPS(cros_ec_lpc_suspend, cros_ec_lpc_resume)

};

drivers/platform/chrome/cros_ec_sysfs.c

+1 −1
Original line number Diff line number Diff line
@@ -335,7 +335,7 @@ static umode_t cros_ec_ctrl_visible(struct kobject *kobj, 
	return a->mode;

}



struct attribute_group cros_ec_attr_group = {

static struct attribute_group cros_ec_attr_group = {

	.attrs = __ec_attrs,

	.is_visible = cros_ec_ctrl_visible,

};

drivers/platform/chrome/cros_ec_vbc.c

+1 −1
Original line number Diff line number Diff line
@@ -101,7 +101,7 @@ static struct bin_attribute *cros_ec_vbc_bin_attrs[] = { 
	NULL

};



struct attribute_group cros_ec_vbc_attr_group = {

static struct attribute_group cros_ec_vbc_attr_group = {

	.name = "vbc",

	.bin_attrs = cros_ec_vbc_bin_attrs,

};

CRA Git | Maintained and supported by SUSTech CRA and CCSE