Commit 81baf90a authored by Bhaktipriya Shridhar's avatar Bhaktipriya Shridhar Committed by Jens Axboe
Browse files

bcache: Remove deprecated create_workqueue 



alloc_workqueue replaces deprecated create_workqueue().

Dedicated workqueues have been used since bcache_wq and moving_gc_wq
are workqueues for writes and are being used on a memory reclaim path.
WQ_MEM_RECLAIM has been set to ensure forward progress under memory
pressure.
Since there are only a fixed number of work items, explicit concurrency
limit is unnecessary here.

Signed-off-by: default avatarBhaktipriya Shridhar <bhaktipriya96@gmail.com>
Acked-by: default avatarTejun Heo <tj@kernel.org>
Signed-off-by: default avatarJens Axboe <axboe@fb.com>
parent 288dab8a

drivers/md/bcache/super.c

+3 −2
Original line number Diff line number Diff line
@@ -1520,7 +1520,8 @@ struct cache_set *bch_cache_set_alloc(struct cache_sb *sb) 
	    !(c->fill_iter = mempool_create_kmalloc_pool(1, iter_size)) ||

	    !(c->bio_split = bioset_create(4, offsetof(struct bbio, bio))) ||

	    !(c->uuids = alloc_bucket_pages(GFP_KERNEL, c)) ||

	    !(c->moving_gc_wq = create_workqueue("bcache_gc")) ||

	    !(c->moving_gc_wq = alloc_workqueue("bcache_gc",

						WQ_MEM_RECLAIM, 0)) ||

	    bch_journal_alloc(c) ||

	    bch_btree_cache_alloc(c) ||

	    bch_open_buckets_alloc(c) ||
@@ -2099,7 +2100,7 @@ static int __init bcache_init(void) 
		return bcache_major;

	}



	if (!(bcache_wq = create_workqueue("bcache")) ||

	if (!(bcache_wq = alloc_workqueue("bcache", WQ_MEM_RECLAIM, 0)) ||

	    !(bcache_kobj = kobject_create_and_add("bcache", fs_kobj)) ||

	    sysfs_create_files(bcache_kobj, files) ||

	    bch_request_init() ||

CRA Git | Maintained and supported by SUSTech CRA and CCSE