Commit 81b94f14 authored Jul 04, 2019 by Fuqian Huang Committed by Stephen Boyd Sep 06, 2019

clk/ti: Use kmemdup rather than duplicating its implementation

kmemdup is introduced to duplicate a region of memory in a neat way.
Rather than kmalloc/kzalloc + memcpy, which the programmer needs to
write the size twice (sometimes lead to mistakes), kmemdup improves
readability, leads to smaller code and also reduce the chances of mistakes.
Suggestion to use kmemdup rather than using kmalloc/kzalloc + memcpy.

Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
Link: https://lkml.kernel.org/r/20190703162700.32091-1-huangfq.daxian@gmail.com

Signed-off-by: Stephen Boyd <sboyd@kernel.org>

parent f9d67cd7

drivers/clk/ti/dpll.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -291,14 +291,12 @@ static void __init of_ti_dpll_setup(struct device_node *node,
		struct dpll_data *dd = NULL;
		u8 dpll_mode = 0;

		dd = kzalloc(sizeof(*dd), GFP_KERNEL);
		dd = kmemdup(ddt, sizeof(*dd), GFP_KERNEL);
		clk_hw = kzalloc(sizeof(*clk_hw), GFP_KERNEL);
		init = kzalloc(sizeof(*init), GFP_KERNEL);
		if (!dd \|\| !clk_hw \|\| !init)
		goto cleanup;

		memcpy(dd, ddt, sizeof(*dd));

		clk_hw->dpll_data = dd;
		clk_hw->ops = &clkhwops_omap3_dpll;
		clk_hw->hw.init = init;