Commit 81b1251d authored Jun 04, 2016 by Yuval Mintz Committed by David S. Miller Jun 03, 2016

qed: Fix next-ptr chains for BE / 32-bit



Commit a91eb52a ("qed: Revisit chain implementation") contains an
incorrect implementation for BE platforms, as device's regpairs containing
addresses are LE and they're not converted correctly when read back.
In addition, it raises a compilation warning for 32-bit platforms where
dma_addr_t is a 32-bit variable.

Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Yuval Mintz <Yuval.Mintz@qlogic.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 03c7f70b

include/linux/qed/qed_chain.h

+1 −2

Original line number	Diff line number	Diff line
		@@ -25,10 +25,9 @@
		} while (0)

		#define HILO_GEN(hi, lo, type) ((((type)(hi)) << 32) + (lo))
		#define HILO_DMA(hi, lo) HILO_GEN(hi, lo, dma_addr_t)
		#define HILO_64(hi, lo) HILO_GEN((le32_to_cpu(hi)), (le32_to_cpu(lo)), u64)
		#define HILO_DMA_REGPAIR(regpair) (HILO_DMA(regpair.hi, regpair.lo))
		#define HILO_64_REGPAIR(regpair) (HILO_64(regpair.hi, regpair.lo))
		#define HILO_DMA_REGPAIR(regpair) ((dma_addr_t)HILO_64_REGPAIR(regpair))

		enum qed_chain_mode {
		/* Each Page contains a next pointer at its end */

Admin message