Commit 81a7be2c authored Dec 08, 2017 by Eric Biggers Committed by David Howells Dec 08, 2017

ASN.1: check for error from ASN1_OP_END__ACT actions



asn1_ber_decoder() was ignoring errors from actions associated with the
opcodes ASN1_OP_END_SEQ_ACT, ASN1_OP_END_SET_ACT,
ASN1_OP_END_SEQ_OF_ACT, and ASN1_OP_END_SET_OF_ACT.  In practice, this
meant the pkcs7_note_signed_info() action (since that was the only user
of those opcodes).  Fix it by checking for the error, just like the
decoder does for actions associated with the other opcodes.

This bug allowed users to leak slab memory by repeatedly trying to add a
specially crafted "pkcs7_test" key (requires CONFIG_PKCS7_TEST_KEY).

In theory, this bug could also be used to bypass module signature
verification, by providing a PKCS#7 message that is misparsed such that
a signature's ->authattrs do not contain its ->msgdigest.  But it
doesn't seem practical in normal cases, due to restrictions on the
format of the ->authattrs.

Fixes: 42d5ec27 ("X.509: Add an ASN.1 decoder")
Cc: <stable@vger.kernel.org> # v3.7+
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: David Howells <dhowells@redhat.com>
Reviewed-by: James Morris <james.l.morris@oracle.com>

parent e0058f3a

lib/asn1_decoder.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -439,6 +439,8 @@ next_op:
		else
		act = machine[pc + 1];
		ret = actions[act](context, hdr, 0, data + tdp, len);
		if (ret < 0)
		return ret;
		}
		pc += asn1_op_lengths[op];
		goto next_op;

Admin message