Commit 81a42d29 authored Aug 25, 2006 by Jeff Mahoney Committed by David S. Miller Aug 26, 2006

[DISKLABEL] SUN: Fix signed int usage for sector count



The current sun disklabel code uses a signed int for the sector count.
When partitions larger than 1 TB are used, the cast to a sector_t causes
the partition sizes to be invalid:

 # cat /proc/paritions | grep sdan
   66   112 2146435072 sdan
   66   115 9223372036853660736 sdan3
   66   120 9223372036853660736 sdan8

This patch switches the sector count to an unsigned int to fix this.

Signed-off-by: Jeff Mahoney <jeffm@suse.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 5fec811e

fs/partitions/sun.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -74,7 +74,7 @@ int sun_partition(struct parsed_partitions state, struct block_device bdev)
		spc = be16_to_cpu(label->ntrks) * be16_to_cpu(label->nsect);
		for (i = 0; i < 8; i++, p++) {
		unsigned long st_sector;
		int num_sectors;
		unsigned int num_sectors;

		st_sector = be32_to_cpu(p->start_cylinder) * spc;
		num_sectors = be32_to_cpu(p->num_sectors);

Admin message