sctp: Fix the SNMP counter of SCTP_MIB_OUTOFBLUES (8190f89d) · Commits · 戴 / test

RFC3873 defined SCTP_MIB_OUTOFBLUES: sctpOutOfBlues OBJECT-TYPE SYNTAX Counter32 MAX-ACCESS read-only STATUS current DESCRIPTION "The number of out of the blue packets received by the host. An out of the blue packet is an SCTP packet correctly formed, including the proper checksum, but for which the receiver was unable to identify an appropriate association." REFERENCE "Section 8.4 in RFC2960 deals with the Out-Of-The-Blue (OOTB) packet definition and procedures." But OOTB packet INIT, INIT-ACK and SHUTDOWN-ACK(COOKIE-WAIT or COOKIE-ECHOED state) are not counted by SCTP_MIB_OUTOFBLUES. Case 1(INIT): Endpoint A Endpoint B (CLOSED) (CLOSED) INIT ----------> <---------- ABORT Case 2(INIT-ACK): Endpoint A Endpoint B (CLOSED) (CLOSED) INIT-ACK ----------> <---------- ABORT Case 3(SHUTDOWN-ACK): Endpoint A Endpoint B (CLOSED) (CLOSED) <---------- INIT SHUTDOWN-ACK ----------> <---------- SHUTDOWN-COMPLETE Case 4(SHUTDOWN-ACK): Endpoint A Endpoint B (CLOSED) (COOKIE-ECHOED) SHUTDOWN-ACK ----------> <---------- SHUTDOWN-COMPLETE This patch fixed the problem. Signed-off-by:

Wei Yongjun <yjwei@cn.fujitsu.com> Signed-off-by:

Vlad Yasevich <vladislav.yasevich@hp.com>

net/sctp/sm_statefuns.c

+8 −2

Original line number	Diff line number	Diff line
		@@ -315,8 +315,10 @@ sctp_disposition_t sctp_sf_do_5_1B_init(const struct sctp_endpoint *ep,
		/* If the packet is an OOTB packet which is temporarily on the
		* control endpoint, respond with an ABORT.
		*/
		if (ep == sctp_sk((sctp_get_ctl_sock()))->ep)
		if (ep == sctp_sk((sctp_get_ctl_sock()))->ep) {
		SCTP_INC_STATS(SCTP_MIB_OUTOFBLUES);
		return sctp_sf_tabort_8_4_8(ep, asoc, type, arg, commands);
		}

		/* 3.1 A packet containing an INIT chunk MUST have a zero Verification
		* Tag.
		@@ -635,8 +637,10 @@ sctp_disposition_t sctp_sf_do_5_1D_ce(const struct sctp_endpoint *ep,
		/* If the packet is an OOTB packet which is temporarily on the
		* control endpoint, respond with an ABORT.
		*/
		if (ep == sctp_sk((sctp_get_ctl_sock()))->ep)
		if (ep == sctp_sk((sctp_get_ctl_sock()))->ep) {
		SCTP_INC_STATS(SCTP_MIB_OUTOFBLUES);
		return sctp_sf_tabort_8_4_8(ep, asoc, type, arg, commands);
		}

		/* Make sure that the COOKIE_ECHO chunk has a valid length.
		* In this case, we check that we have enough for at least a
		@@ -3378,6 +3382,8 @@ sctp_disposition_t sctp_sf_do_8_5_1_E_sa(const struct sctp_endpoint *ep,
		* packet and the state function that handles OOTB SHUTDOWN_ACK is
		* called with a NULL association.
		*/
		SCTP_INC_STATS(SCTP_MIB_OUTOFBLUES);

		return sctp_sf_shut_8_4_5(ep, NULL, type, arg, commands);
		}

Admin message