Commit 818f4da5 authored by Ying Xue's avatar Ying Xue Committed by Paul Gortmaker
Browse files

tipc: remove supportable flag from bclink structure 



The "supportable" flag in bclink structure is a compatibility flag
indicating whether a peer node is capable of receiving TIPC broadcast
messages. However, all TIPC versions since tipc-1.5, and after the
inclusion in the upstream Linux kernel in 2006, support this capability.
It is highly unlikely that anybody is still using such an old
version of TIPC, let alone that they want to mix it with TIPC-2.0
nodes. Therefore, we now remove the "supportable" flag.

Signed-off-by: default avatarYing Xue <ying.xue@windriver.com>
Signed-off-by: default avatarJon Maloy <jon.maloy@ericsson.com>
Signed-off-by: default avatarPaul Gortmaker <paul.gortmaker@windriver.com>
parent 3c294cb3

net/tipc/link.c

+1 −3
Original line number Diff line number Diff line
@@ -1426,8 +1426,7 @@ static void link_retransmit_failure(struct tipc_link *l_ptr, 


		tipc_addr_string_fill(addr_string, n_ptr->addr);

		pr_info("Broadcast link info for %s\n", addr_string);

		pr_info("Supportable: %d,  Supported: %d,  Acked: %u\n",

			n_ptr->bclink.supportable,

		pr_info("Supported: %d,  Acked: %u\n",

			n_ptr->bclink.supported,

			n_ptr->bclink.acked);

		pr_info("Last in: %u,  Oos state: %u,  Last sent: %u\n",
@@ -2014,7 +2013,6 @@ static void link_recv_proto_msg(struct tipc_link *l_ptr, struct sk_buff *buf) 
		} else {

			l_ptr->max_pkt = l_ptr->max_pkt_target;

		}

		l_ptr->owner->bclink.supportable = (max_pkt_info != 0);



		/* Synchronize broadcast link info, if not done previously */

		if (!tipc_node_is_up(l_ptr->owner)) {

net/tipc/node.c

+3 −5
Original line number Diff line number Diff line
@@ -264,12 +264,10 @@ static void node_established_contact(struct tipc_node *n_ptr) 
{

	tipc_k_signal((Handler)tipc_named_node_up, n_ptr->addr);



	if (n_ptr->bclink.supportable) {

	n_ptr->bclink.acked = tipc_bclink_get_last_sent();

	tipc_bclink_add_node(n_ptr->addr);

	n_ptr->bclink.supported = 1;

}

}



static void node_name_purge_complete(unsigned long node_addr)

{

net/tipc/node.h

+0 −2
Original line number Diff line number Diff line
@@ -67,7 +67,6 @@ 
 * @permit_changeover: non-zero if node has redundant links to this system

 * @signature: node instance identifier

 * @bclink: broadcast-related info

 *    @supportable: non-zero if node supports TIPC b'cast link capability

 *    @supported: non-zero if node supports TIPC b'cast capability

 *    @acked: sequence # of last outbound b'cast message acknowledged by node

 *    @last_in: sequence # of last in-sequence b'cast message received from node
@@ -92,7 +91,6 @@ struct tipc_node { 
	int permit_changeover;

	u32 signature;

	struct {

		u8 supportable;

		u8 supported;

		u32 acked;

		u32 last_in;

CRA Git | Maintained and supported by SUSTech CRA and CCSE