Commit 816df944 authored by Marco Felsch's avatar Marco Felsch Committed by Philipp Zabel
Browse files

drm/imx: drop useless best_encoder callback 



The best_encoder() callback is used by the drm-core to find an encoder
if the connector is connected to multiple encoders but the parallel, tve
and ldb uses always the 1-encoder : 1-connector setup. Such a simple
setup can be handled by the drm-core.

Signed-off-by: default avatarMarco Felsch <m.felsch@pengutronix.de>
Reviewed-by: default avatarPhilipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: default avatarPhilipp Zabel <p.zabel@pengutronix.de>
parent 7bb58b98

drivers/gpu/drm/imx/imx-ldb.c

+0 −9
Original line number Diff line number Diff line
@@ -156,14 +156,6 @@ static int imx_ldb_connector_get_modes(struct drm_connector *connector) 
	return num_modes;

}



static struct drm_encoder *imx_ldb_connector_best_encoder(

		struct drm_connector *connector)

{

	struct imx_ldb_channel *imx_ldb_ch = con_to_imx_ldb_ch(connector);



	return &imx_ldb_ch->encoder;

}



static void imx_ldb_set_clock(struct imx_ldb *ldb, int mux, int chno,

		unsigned long serial_clk, unsigned long di_clk)

{
@@ -391,7 +383,6 @@ static const struct drm_connector_funcs imx_ldb_connector_funcs = { 


static const struct drm_connector_helper_funcs imx_ldb_connector_helper_funcs = {

	.get_modes = imx_ldb_connector_get_modes,

	.best_encoder = imx_ldb_connector_best_encoder,

};



static const struct drm_encoder_helper_funcs imx_ldb_encoder_helper_funcs = {

drivers/gpu/drm/imx/imx-tve.c

+0 −9
Original line number Diff line number Diff line
@@ -260,14 +260,6 @@ static int imx_tve_connector_mode_valid(struct drm_connector *connector, 
	return MODE_BAD;

}



static struct drm_encoder *imx_tve_connector_best_encoder(

		struct drm_connector *connector)

{

	struct imx_tve *tve = con_to_tve(connector);



	return &tve->encoder;

}



static void imx_tve_encoder_mode_set(struct drm_encoder *encoder,

				     struct drm_display_mode *orig_mode,

				     struct drm_display_mode *mode)
@@ -345,7 +337,6 @@ static const struct drm_connector_funcs imx_tve_connector_funcs = { 


static const struct drm_connector_helper_funcs imx_tve_connector_helper_funcs = {

	.get_modes = imx_tve_connector_get_modes,

	.best_encoder = imx_tve_connector_best_encoder,

	.mode_valid = imx_tve_connector_mode_valid,

};

drivers/gpu/drm/imx/parallel-display.c

+0 −9
Original line number Diff line number Diff line
@@ -88,14 +88,6 @@ static int imx_pd_connector_get_modes(struct drm_connector *connector) 
	return num_modes;

}



static struct drm_encoder *imx_pd_connector_best_encoder(

		struct drm_connector *connector)

{

	struct imx_parallel_display *imxpd = con_to_imxpd(connector);



	return &imxpd->encoder;

}



static void imx_pd_bridge_enable(struct drm_bridge *bridge)

{

	struct imx_parallel_display *imxpd = bridge_to_imxpd(bridge);
@@ -254,7 +246,6 @@ static const struct drm_connector_funcs imx_pd_connector_funcs = { 


static const struct drm_connector_helper_funcs imx_pd_connector_helper_funcs = {

	.get_modes = imx_pd_connector_get_modes,

	.best_encoder = imx_pd_connector_best_encoder,

};



static const struct drm_bridge_funcs imx_pd_bridge_funcs = {

CRA Git | Maintained and supported by SUSTech CRA and CCSE