Commit 816ab897 authored Oct 22, 2008 by Tejun Heo Committed by Jeff Garzik Oct 22, 2008

libata: set device class to NONE if phys_offline



Reset methods don't have access to phys link status for slave links
and may incorrectly indicate device presence causing unnecessary probe
failures for unoccupied links.  This patch clears device class to NONE
during post-reset processing if phys link is offline.

As on/offlineness semantics is strictly defined and used in multiple
places by the core layer, this won't change behavior for drivers which
don't use slave links.

Signed-off-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>

parent a568d1d2

drivers/ata/libata-eh.c

+8 −8

Original line number	Diff line number	Diff line
		@@ -2455,14 +2455,14 @@ int ata_eh_reset(struct ata_link *link, int classify,
		dev->pio_mode = XFER_PIO_0;
		dev->flags &= ~ATA_DFLAG_SLEEPING;

		if (ata_phys_link_offline(ata_dev_phys_link(dev)))
		continue;

		if (!ata_phys_link_offline(ata_dev_phys_link(dev))) {
		/* apply class override */
		if (lflags & ATA_LFLAG_ASSUME_ATA)
		classes[dev->devno] = ATA_DEV_ATA;
		else if (lflags & ATA_LFLAG_ASSUME_SEMB)
		classes[dev->devno] = ATA_DEV_SEMB_UNSUP; /* not yet */
		classes[dev->devno] = ATA_DEV_SEMB_UNSUP;
		} else
		classes[dev->devno] = ATA_DEV_NONE;
		}

		/* record current link speed */

Admin message