Commit 8169b5d2 authored by Grant Grundler's avatar Grant Grundler Committed by Greg Kroah-Hartman
Browse files

[PATCH] PCI: make it easier to see that set_msi_affinity() is used 



I missed this usage in drivers/pci/msi.h:

#ifdef CONFIG_SMP
#define set_msi_irq_affinity    set_msi_affinity
#else
#define set_msi_irq_affinity    NULL
#endif

set_msi_affinity() is declared and exclusively used in msi.c.
Here's a better way so (hopefully) history doesn't repeat itself.

Signed-off-by: default avatarGrant Grundler <iod00d@hp.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent f8d65713

drivers/pci/msi.c

+5 −3
Original line number Diff line number Diff line
@@ -137,6 +137,8 @@ static void set_msi_affinity(unsigned int vector, cpumask_t cpu_mask) 
		break;

	}

}

#else

#define set_msi_affinity NULL

#endif /* CONFIG_SMP */



static void mask_MSI_irq(unsigned int vector)
@@ -214,7 +216,7 @@ static struct hw_interrupt_type msix_irq_type = { 
	.disable	= mask_MSI_irq,

	.ack		= mask_MSI_irq,

	.end		= end_msi_irq_w_maskbit,

	.set_affinity	= set_msi_irq_affinity

	.set_affinity	= set_msi_affinity

};



/*
@@ -230,7 +232,7 @@ static struct hw_interrupt_type msi_irq_w_maskbit_type = { 
	.disable	= mask_MSI_irq,

	.ack		= mask_MSI_irq,

	.end		= end_msi_irq_w_maskbit,

	.set_affinity	= set_msi_irq_affinity

	.set_affinity	= set_msi_affinity

};



/*
@@ -246,7 +248,7 @@ static struct hw_interrupt_type msi_irq_wo_maskbit_type = { 
	.disable	= do_nothing,

	.ack		= do_nothing,

	.end		= end_msi_irq_wo_maskbit,

	.set_affinity	= set_msi_irq_affinity

	.set_affinity	= set_msi_affinity

};



static void msi_data_init(struct msg_data *msi_data,

drivers/pci/msi.h

+0 −6
Original line number Diff line number Diff line
@@ -22,12 +22,6 @@ extern int vector_irq[NR_VECTORS]; 
extern void (*interrupt[NR_IRQS])(void);

extern int pci_vector_resources(int last, int nr_released);



#ifdef CONFIG_SMP

#define set_msi_irq_affinity	set_msi_affinity

#else

#define set_msi_irq_affinity	NULL

#endif



/*

 * MSI-X Address Register

 */

CRA Git | Maintained and supported by SUSTech CRA and CCSE