Unverified Commit 81630dc0 authored Apr 02, 2020 by Hans de Goede Committed by Mark Brown Apr 03, 2020

ASoC: Intel: atom: Take the drv->lock mutex before calling sst_send_slot_map()

sst_send_slot_map() uses sst_fill_and_send_cmd_unlocked() because in some
places it is called with the drv->lock mutex already held.

So it must always be called with the mutex locked. This commit adds missing
locking in the sst_set_be_modules() code-path.

Fixes: 24c8d141 ("ASoC: Intel: mrfld: add DSP core controls")
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20200402185359.3424-1-hdegoede@redhat.com

Signed-off-by: Mark Brown <broonie@kernel.org>

parent 904f353d

sound/soc/intel/atom/sst-atom-controls.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -966,7 +966,9 @@ static int sst_set_be_modules(struct snd_soc_dapm_widget *w,
		dev_dbg(c->dev, "Enter: widget=%s\n", w->name);

		if (SND_SOC_DAPM_EVENT_ON(event)) {
		mutex_lock(&drv->lock);
		ret = sst_send_slot_map(drv);
		mutex_unlock(&drv->lock);
		if (ret)
		return ret;
		ret = sst_send_pipe_module_params(w, k);