tools lib api: Add str_error_c to libapi (8149a774) · Commits · 戴 / test

Because it uses that function, which would lead every tool using it to need to link against tools/lib/str_error_r.o. This fixes building tools/vm/, that links with libapi. Reported-by:

Arjan van de Ven <arjan@linux.intel.com> Reported-by:

Randy Dunlap <rdunlap@infradead.org> Cc: Adrian Hunter <adrian.hunter@intel.com> Cc: David Ahern <dsahern@gmail.com> Cc: Jiri Olsa <jolsa@kernel.org> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Wang Nan <wangnan0@huawei.com> Fixes: ("tools lib api fs: Use str_error_r()") Link: http://lkml.kernel.org/n/tip-aedt3qzibhnhaov2j4caqi61@git.kernel.org Signed-off-by:

Arnaldo Carvalho de Melo <acme@redhat.com>

tools/lib/api/Build

+5 −0

Original line number	Diff line number	Diff line
		@@ -2,3 +2,8 @@ libapi-y += fd/
		libapi-y += fs/
		libapi-y += cpu.o
		libapi-y += debug.o
		libapi-y += str_error_r.o

		$(OUTPUT)str_error_r.o: ../str_error_r.c FORCE
		$(call rule_mkdir)
		$(call if_changed_dep,cc_o_c)

tools/perf/util/Build

+0 −5

Original line number	Diff line number	Diff line
		@@ -70,7 +70,6 @@ libperf-y += stat.o
		libperf-y += stat-shadow.o
		libperf-y += record.o
		libperf-y += srcline.o
		libperf-y += str_error_r.o
		libperf-y += data.o
		libperf-y += tsc.o
		libperf-y += cloexec.o
		@@ -176,10 +175,6 @@ $(OUTPUT)util/libstring.o: ../lib/string.c FORCE
		$(call rule_mkdir)
		$(call if_changed_dep,cc_o_c)

		$(OUTPUT)util/str_error_r.o: ../lib/str_error_r.c FORCE
		$(call rule_mkdir)
		$(call if_changed_dep,cc_o_c)

		$(OUTPUT)util/hweight.o: ../lib/hweight.c FORCE
		$(call rule_mkdir)
		$(call if_changed_dep,cc_o_c)

tools/perf/util/python-ext-sources

+0 −1

Original line number	Diff line number	Diff line
		@@ -13,7 +13,6 @@ util/cpumap.c
		../lib/bitmap.c
		../lib/find_bit.c
		../lib/hweight.c
		../lib/str_error_r.c
		../lib/vsprintf.c
		util/thread_map.c
		util/util.c

Admin message