Commit 814740d5 authored by Bhanu Prakash Gollapudi's avatar Bhanu Prakash Gollapudi Committed by James Bottomley
Browse files

[SCSI] fcoe,libfcoe: Move common code for fcoe_get_lesb to fcoe_transport 



Except for obtaining the netdev from lport, fcoe_get_lesb is the common code
for the LLDs.

Signed-off-by: default avatarBhanu Prakash Gollapudi <bprakash@broadcom.com>
Acked-by: default avatarYi Zou <yi.zou@intel.com>
Signed-off-by: default avatarJames Bottomley <JBottomley@Parallels.com>
parent fd8fa907

drivers/scsi/fcoe/fcoe.c

+1 −20
Original line number Diff line number Diff line
@@ -2541,28 +2541,9 @@ static void fcoe_set_vport_symbolic_name(struct fc_vport *vport) 
static void fcoe_get_lesb(struct fc_lport *lport,

			 struct fc_els_lesb *fc_lesb)

{

	unsigned int cpu;

	u32 lfc, vlfc, mdac;

	struct fcoe_dev_stats *devst;

	struct fcoe_fc_els_lesb *lesb;

	struct rtnl_link_stats64 temp;

	struct net_device *netdev = fcoe_netdev(lport);



	lfc = 0;

	vlfc = 0;

	mdac = 0;

	lesb = (struct fcoe_fc_els_lesb *)fc_lesb;

	memset(lesb, 0, sizeof(*lesb));

	for_each_possible_cpu(cpu) {

		devst = per_cpu_ptr(lport->dev_stats, cpu);

		lfc += devst->LinkFailureCount;

		vlfc += devst->VLinkFailureCount;

		mdac += devst->MissDiscAdvCount;

	}

	lesb->lesb_link_fail = htonl(lfc);

	lesb->lesb_vlink_fail = htonl(vlfc);

	lesb->lesb_miss_fka = htonl(mdac);

	lesb->lesb_fcs_error = htonl(dev_get_stats(netdev, &temp)->rx_crc_errors);

	__fcoe_get_lesb(lport, fc_lesb, netdev);

}



/**

drivers/scsi/fcoe/fcoe_transport.c

+29 −0
Original line number Diff line number Diff line
@@ -83,6 +83,35 @@ static struct notifier_block libfcoe_notifier = { 
	.notifier_call = libfcoe_device_notification,

};



void __fcoe_get_lesb(struct fc_lport *lport,

		     struct fc_els_lesb *fc_lesb,

		     struct net_device *netdev)

{

	unsigned int cpu;

	u32 lfc, vlfc, mdac;

	struct fcoe_dev_stats *devst;

	struct fcoe_fc_els_lesb *lesb;

	struct rtnl_link_stats64 temp;



	lfc = 0;

	vlfc = 0;

	mdac = 0;

	lesb = (struct fcoe_fc_els_lesb *)fc_lesb;

	memset(lesb, 0, sizeof(*lesb));

	for_each_possible_cpu(cpu) {

		devst = per_cpu_ptr(lport->dev_stats, cpu);

		lfc += devst->LinkFailureCount;

		vlfc += devst->VLinkFailureCount;

		mdac += devst->MissDiscAdvCount;

	}

	lesb->lesb_link_fail = htonl(lfc);

	lesb->lesb_vlink_fail = htonl(vlfc);

	lesb->lesb_miss_fka = htonl(mdac);

	lesb->lesb_fcs_error =

			htonl(dev_get_stats(netdev, &temp)->rx_crc_errors);

}

EXPORT_SYMBOL_GPL(__fcoe_get_lesb);



void fcoe_wwn_to_str(u64 wwn, char *buf, int len)

{

	u8 wwpn[8];

include/scsi/libfcoe.h

+2 −0
Original line number Diff line number Diff line
@@ -230,6 +230,8 @@ int fcoe_libfc_config(struct fc_lport *, struct fcoe_ctlr *, 
u32 fcoe_fc_crc(struct fc_frame *fp);

int fcoe_start_io(struct sk_buff *skb);

int fcoe_get_wwn(struct net_device *netdev, u64 *wwn, int type);

void __fcoe_get_lesb(struct fc_lport *lport, struct fc_els_lesb *fc_lesb,

		     struct net_device *netdev);

void fcoe_wwn_to_str(u64 wwn, char *buf, int len);

int fcoe_validate_vport_create(struct fc_vport *vport);

CRA Git | Maintained and supported by SUSTech CRA and CCSE