Commit 814723e0 authored Jul 02, 2020 by Nikolay Borisov Committed by David Sterba Jul 27, 2020

btrfs: increment device corruption error in case of checksum error

Now that btrfs_io_bio have access to btrfs_device we can safely
increment the device corruption counter on error. There is one notable
exception - repair bios for raid. Since those don't go through the
normal submit_stripe_bio callpath but through raid56_parity_recover thus
repair bios won't have their device set.

Scrub increments the corruption counter for checksum mismatch as well
but does not call this function.

Link: https://lore.kernel.org/linux-btrfs/4857863.FCrPRfMyHP@liv/


Reviewed-by: Josef Bacik <josef@toxicpanda.com>
Signed-off-by: Nikolay Borisov <nborisov@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>

parent 3eee86c8

fs/btrfs/inode.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -2815,6 +2815,9 @@ static int check_data_csum(struct inode inode, struct btrfs_io_bio io_bio,
		zeroit:
		btrfs_print_data_csum_error(BTRFS_I(inode), start, csum, csum_expected,
		io_bio->mirror_num);
		if (io_bio->device)
		btrfs_dev_stat_inc_and_print(io_bio->device,
		BTRFS_DEV_STAT_CORRUPTION_ERRS);
		memset(kaddr + pgoff, 1, len);
		flush_dcache_page(page);
		kunmap_atomic(kaddr);

Admin message