Commit 814625b5 authored Feb 12, 2016 by Amitoj Kaur Chawla Committed by Greg Kroah-Hartman Feb 14, 2016

staging: goldfish: goldfish_nand: Return correct error code



The return value of devm_kzalloc on failure of allocation of memory should
be -ENOMEM and not -1.

Found using Coccinelle. A simplified version of the semantic patch
used is:

//<smpl>
@@
expression *e;
@@

e = devm_kzalloc(...);
if (e == NULL) {
...
return
- -1
+ -ENOMEM
;
}
//</smpl>

The single call site does not perform any checks on the return value, hence
no change is required at the call site.

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent c272dc2d

drivers/staging/goldfish/goldfish_nand.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -290,7 +290,7 @@ static int nand_setup_cmd_params(struct platform_device *pdev,
		nand->cmd_params = devm_kzalloc(&pdev->dev,
		sizeof(struct cmd_params), GFP_KERNEL);
		if (!nand->cmd_params)
		return -1;
		return -ENOMEM;

		paddr = __pa(nand->cmd_params);
		writel((u32)(paddr >> 32), base + NAND_CMD_PARAMS_ADDR_HIGH);

Admin message