Commit 81414b4d authored Nov 27, 2020 by Jan Kara Committed by Theodore Ts'o Dec 17, 2020

ext4: remove redundant sb checksum recomputation



Superblock is written out either through ext4_commit_super() or through
ext4_handle_dirty_super(). In both cases we recompute the checksum so it
is not necessary to recompute it after updating superblock free inodes &
blocks counters.

Signed-off-by: Jan Kara <jack@suse.cz>
Reviewed-by: Andreas Dilger <adilger@dilger.ca>
Link: https://lore.kernel.org/r/20201127113405.26867-3-jack@suse.cz


Signed-off-by: Theodore Ts'o <tytso@mit.edu>

parent b08070ec

fs/ext4/super.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -5010,13 +5010,11 @@ no_journal:
		block = ext4_count_free_clusters(sb);
		ext4_free_blocks_count_set(sbi->s_es,
		EXT4_C2B(sbi, block));
		ext4_superblock_csum_set(sb);
		err = percpu_counter_init(&sbi->s_freeclusters_counter, block,
		GFP_KERNEL);
		if (!err) {
		unsigned long freei = ext4_count_free_inodes(sb);
		sbi->s_es->s_free_inodes_count = cpu_to_le32(freei);
		ext4_superblock_csum_set(sb);
		err = percpu_counter_init(&sbi->s_freeinodes_counter, freei,
		GFP_KERNEL);
		}

Admin message