Commit 813820b9 authored Dec 09, 2007 by Al Viro Committed by Jeff Garzik Dec 14, 2007

starfire VLAN fix

Recognized VLAN ids are set via writew(), should go in host-endian.
That's a long-standing bug, BTW - see http://lkml.org/lkml/2004/2/27/180

for example. What happens is that card gets VLAN id table populated by
byteswapped values on little-endian boxen (so 257 works as expected, 256
and 258 do not, etc.). Bug is easily reproduced, patch fixes it.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Jeff Garzik <jeff@garzik.org>

parent 14c9d9b0

drivers/net/starfire.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1742,7 +1742,7 @@ static void set_rx_mode(struct net_device *dev)
		if (vlan_group_get_device(np->vlgrp, i)) {
		if (vlan_count >= 32)
		break;
		writew(cpu_to_be16(i), filter_addr);
		writew(i, filter_addr);
		filter_addr += 16;
		vlan_count++;
		}

Admin message