Commit 81380ca1 authored by Omar Sandoval's avatar Omar Sandoval Committed by Jens Axboe
Browse files

blk-mq: use the right hctx when getting a driver tag fails 



While dispatching requests, if we fail to get a driver tag, we mark the
hardware queue as waiting for a tag and put the requests on a
hctx->dispatch list to be run later when a driver tag is freed. However,
blk_mq_dispatch_rq_list() may dispatch requests from multiple hardware
queues if using a single-queue scheduler with a multiqueue device. If
blk_mq_get_driver_tag() fails, it doesn't update the hardware queue we
are processing. This means we end up using the hardware queue of the
previous request, which may or may not be the same as that of the
current request. If it isn't, the wrong hardware queue will end up
waiting for a tag, and the requests will be on the wrong dispatch list,
leading to a hang.

The fix is twofold:

1. Make sure we save which hardware queue we were trying to get a
   request for in blk_mq_get_driver_tag() regardless of whether it
   succeeds or not.
2. Make blk_mq_dispatch_rq_list() take a request_queue instead of a
   blk_mq_hw_queue to make it clear that it must handle multiple
   hardware queues, since I've already messed this up on a couple of
   occasions.

This didn't appear in testing with nvme and mq-deadline because nvme has
more driver tags than the default number of scheduler tags. However,
with the blk_mq_update_nr_hw_queues() fix, it showed up with nbd.

Signed-off-by: default avatarOmar Sandoval <osandov@fb.com>
Signed-off-by: default avatarJens Axboe <axboe@fb.com>
parent 8945927c

block/blk-mq-sched.c

+5 −4
Original line number Diff line number Diff line
@@ -171,7 +171,8 @@ void blk_mq_sched_put_request(struct request *rq) 


void blk_mq_sched_dispatch_requests(struct blk_mq_hw_ctx *hctx)

{

	struct elevator_queue *e = hctx->queue->elevator;

	struct request_queue *q = hctx->queue;

	struct elevator_queue *e = q->elevator;

	const bool has_sched_dispatch = e && e->type->ops.mq.dispatch_request;

	bool did_work = false;

	LIST_HEAD(rq_list);
@@ -203,10 +204,10 @@ void blk_mq_sched_dispatch_requests(struct blk_mq_hw_ctx *hctx) 
	 */

	if (!list_empty(&rq_list)) {

		blk_mq_sched_mark_restart_hctx(hctx);

		did_work = blk_mq_dispatch_rq_list(hctx, &rq_list);

		did_work = blk_mq_dispatch_rq_list(q, &rq_list);

	} else if (!has_sched_dispatch) {

		blk_mq_flush_busy_ctxs(hctx, &rq_list);

		blk_mq_dispatch_rq_list(hctx, &rq_list);

		blk_mq_dispatch_rq_list(q, &rq_list);

	}



	/*
@@ -222,7 +223,7 @@ void blk_mq_sched_dispatch_requests(struct blk_mq_hw_ctx *hctx) 
			if (!rq)

				break;

			list_add(&rq->queuelist, &rq_list);

		} while (blk_mq_dispatch_rq_list(hctx, &rq_list));

		} while (blk_mq_dispatch_rq_list(q, &rq_list));

	}

}

block/blk-mq.c

+13 −12
Original line number Diff line number Diff line
@@ -845,12 +845,8 @@ bool blk_mq_get_driver_tag(struct request *rq, struct blk_mq_hw_ctx **hctx, 
		.flags = wait ? 0 : BLK_MQ_REQ_NOWAIT,

	};



	if (rq->tag != -1) {

done:

		if (hctx)

			*hctx = data.hctx;

		return true;

	}

	if (rq->tag != -1)

		goto done;



	if (blk_mq_tag_is_reserved(data.hctx->sched_tags, rq->internal_tag))

		data.flags |= BLK_MQ_REQ_RESERVED;
@@ -862,10 +858,12 @@ done: 
			atomic_inc(&data.hctx->nr_active);

		}

		data.hctx->tags->rqs[rq->tag] = rq;

		goto done;

	}



	return false;

done:

	if (hctx)

		*hctx = data.hctx;

	return rq->tag != -1;

}



static void __blk_mq_put_driver_tag(struct blk_mq_hw_ctx *hctx,
@@ -962,14 +960,17 @@ static bool blk_mq_dispatch_wait_add(struct blk_mq_hw_ctx *hctx) 
	return true;

}



bool blk_mq_dispatch_rq_list(struct blk_mq_hw_ctx *hctx, struct list_head *list)

bool blk_mq_dispatch_rq_list(struct request_queue *q, struct list_head *list)

{

	struct request_queue *q = hctx->queue;

	struct blk_mq_hw_ctx *hctx;

	struct request *rq;

	LIST_HEAD(driver_list);

	struct list_head *dptr;

	int errors, queued, ret = BLK_MQ_RQ_QUEUE_OK;



	if (list_empty(list))

		return false;



	/*

	 * Start off with dptr being NULL, so we start the first request

	 * immediately, even if we have more pending.
@@ -980,7 +981,7 @@ bool blk_mq_dispatch_rq_list(struct blk_mq_hw_ctx *hctx, struct list_head *list) 
	 * Now process all the entries, sending them to the driver.

	 */

	errors = queued = 0;

	while (!list_empty(list)) {

	do {

		struct blk_mq_queue_data bd;



		rq = list_first_entry(list, struct request, queuelist);
@@ -1051,7 +1052,7 @@ bool blk_mq_dispatch_rq_list(struct blk_mq_hw_ctx *hctx, struct list_head *list) 
		 */

		if (!dptr && list->next != list->prev)

			dptr = &driver_list;

	}

	} while (!list_empty(list));



	hctx->dispatched[queued_to_index(queued)]++;

block/blk-mq.h

+1 −1
Original line number Diff line number Diff line
@@ -31,7 +31,7 @@ void blk_mq_freeze_queue(struct request_queue *q); 
void blk_mq_free_queue(struct request_queue *q);

int blk_mq_update_nr_requests(struct request_queue *q, unsigned int nr);

void blk_mq_wake_waiters(struct request_queue *q);

bool blk_mq_dispatch_rq_list(struct blk_mq_hw_ctx *, struct list_head *);

bool blk_mq_dispatch_rq_list(struct request_queue *, struct list_head *);

void blk_mq_flush_busy_ctxs(struct blk_mq_hw_ctx *hctx, struct list_head *list);

bool blk_mq_hctx_has_pending(struct blk_mq_hw_ctx *hctx);

bool blk_mq_get_driver_tag(struct request *rq, struct blk_mq_hw_ctx **hctx,

CRA Git | Maintained and supported by SUSTech CRA and CCSE