Commit 810bf110 authored Jun 23, 2016 by Amitoj Kaur Chawla Committed by David S. Miller Jun 27, 2016

tipc: Use kmemdup instead of kmalloc and memcpy



Replace calls to kmalloc followed by a memcpy with a direct call to
kmemdup.

The Coccinelle semantic patch used to make this change is as follows:
@@
expression from,to,size,flag;
statement S;
@@

-  to = \(kmalloc\|kzalloc\)(size,flag);
+  to = kmemdup(from,size,flag);
   if (to==NULL || ...) S
-  memcpy(to, from, size);

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Acked-by: Ying Xue <ying.xue@windriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent ac5fd4f4

net/tipc/server.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -418,13 +418,12 @@ static struct outqueue_entry tipc_alloc_entry(void data, int len)
		if (!entry)
		return NULL;

		buf = kmalloc(len, GFP_ATOMIC);
		buf = kmemdup(data, len, GFP_ATOMIC);
		if (!buf) {
		kfree(entry);
		return NULL;
		}

		memcpy(buf, data, len);
		entry->iov.iov_base = buf;
		entry->iov.iov_len = len;

Admin message