Commit 80f162ff authored May 30, 2016 by Ming Lei Committed by Jens Axboe Jun 09, 2016

block: mark 1st parameter of bvec_iter_advance as const



bvec_iter_advance() only writes the parameter of iterator,
so the base address of bvec can be marked as const safely.

Without the change, we can see compiling warning in the
following patch for implementing iterate_bvec(): lib/iov_iter.c
with bvec iterator.

Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Ming Lei <ming.lei@canonical.com>
Tested-by: Hannes Reinecke <hare@suse.com>
Signed-off-by: Jens Axboe <axboe@fb.com>

parent 0781e79e

include/linux/bvec.h

+2 −1

Original line number	Diff line number	Diff line
		@@ -66,7 +66,8 @@ struct bvec_iter {
		.bv_offset = bvec_iter_offset((bvec), (iter)), \
		})

		static inline void bvec_iter_advance(struct bio_vec bv, struct bvec_iter iter,
		static inline void bvec_iter_advance(const struct bio_vec *bv,
		struct bvec_iter *iter,
		unsigned bytes)
		{
		WARN_ONCE(bytes > iter->bi_size,

Admin message