[media] s5p-tv: Add missing braces around sizeof in sdo_drv.c (80f0dee2) · Commits · 戴 / test

Silences the following checkpatch warnings: WARNING: sizeof *sdev should be sizeof(*sdev) FILE: media/platform/s5p-tv/sdo_drv.c:304: sdev = devm_kzalloc(&pdev->dev, sizeof *sdev, GFP_KERNEL); WARNING: sizeof sdev->sd.name should be sizeof(sdev->sd.name) FILE: media/platform/s5p-tv/sdo_drv.c:394: strlcpy(sdev->sd.name, "s5p-sdo", sizeof sdev->sd.name); Signed-off-by:

Sachin Kamat <sachin.kamat@linaro.org> Acked-by:

Tomasz Stanislawski <t.stanislaws@samsung.com> Signed-off-by:

Sylwester Nawrocki <s.nawrocki@samsung.com> Signed-off-by:

Mauro Carvalho Chehab <mchehab@redhat.com>

drivers/media/platform/s5p-tv/sdo_drv.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -301,7 +301,7 @@ static int __devinit sdo_probe(struct platform_device *pdev)
		struct clk *sclk_vpll;

		dev_info(dev, "probe start\n");
		sdev = devm_kzalloc(&pdev->dev, sizeof *sdev, GFP_KERNEL);
		sdev = devm_kzalloc(&pdev->dev, sizeof(*sdev), GFP_KERNEL);
		if (!sdev) {
		dev_err(dev, "not enough memory.\n");
		ret = -ENOMEM;
		@@ -397,7 +397,7 @@ static int __devinit sdo_probe(struct platform_device *pdev)
		/* configuration of interface subdevice */
		v4l2_subdev_init(&sdev->sd, &sdo_sd_ops);
		sdev->sd.owner = THIS_MODULE;
		strlcpy(sdev->sd.name, "s5p-sdo", sizeof sdev->sd.name);
		strlcpy(sdev->sd.name, "s5p-sdo", sizeof(sdev->sd.name));

		/* set default format */
		sdev->fmt = sdo_find_format(SDO_DEFAULT_STD);

Admin message