Commit 80e46cf2 authored Mar 13, 2019 by Qu Wenruo Committed by David Sterba Apr 29, 2019

btrfs: tree-checker: Enhance chunk checker to validate chunk profile



Btrfs-progs already have a comprehensive type checker, to ensure there
is only 0 (SINGLE profile) or 1 (DUP/RAID0/1/5/6/10) bit set for chunk
profile bits.

Do the same work for kernel.

Reported-by: Yoon Jungyeon <jungyeon@gatech.edu>
Link: https://bugzilla.kernel.org/show_bug.cgi?id=202765


Reviewed-by: Nikolay Borisov <nborisov@suse.com>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: Qu Wenruo <wqu@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>

parent ab4ba2e1

fs/btrfs/tree-checker.c

+7 −0

Original line number	Diff line number	Diff line
		@@ -556,6 +556,13 @@ int btrfs_check_chunk_valid(struct btrfs_fs_info *fs_info,
		return -EUCLEAN;
		}

		if (!is_power_of_2(type & BTRFS_BLOCK_GROUP_PROFILE_MASK) &&
		(type & BTRFS_BLOCK_GROUP_PROFILE_MASK) != 0) {
		chunk_err(fs_info, leaf, chunk, logical,
		"invalid chunk profile flag: 0x%llx, expect 0 or 1 bit set",
		type & BTRFS_BLOCK_GROUP_PROFILE_MASK);
		return -EUCLEAN;
		}
		if ((type & BTRFS_BLOCK_GROUP_TYPE_MASK) == 0) {
		chunk_err(fs_info, leaf, chunk, logical,
		"missing chunk type flag, have 0x%llx one bit must be set in 0x%llx",

Admin message