signal/ia64: Document a conflict with SI_USER with SIGFPE (80dce5e3) · Commits · 戴 / test

Setting si_code to __SI_FAULT results in a userspace seeing an si_code of 0. This is the same si_code as SI_USER. Posix and common sense requires that SI_USER not be a signal specific si_code. As such this use of 0 for the si_code is a pretty horribly broken ABI. Given that ia64 is on it's last legs I don't know that it is worth fixing this, but it is worth documenting what is going on so that no one decides to copy this bad decision. This was introduced in 2.3.51 so this mess has had a long time for people to be able to start depending on it. Cc: Tony Luck <tony.luck@intel.com> Cc: Fenghua Yu <fenghua.yu@intel.com> Cc: linux-ia64@vger.kernel.org Signed-off-by:

"Eric W. Biederman" <ebiederm@xmission.com>

arch/ia64/include/uapi/asm/siginfo.h

+3 −0

Original line number	Diff line number	Diff line
		@@ -107,6 +107,9 @@ typedef struct siginfo {
		/*
		* SIGFPE si_codes
		*/
		#ifdef __KERNEL__
		#define FPE_FIXME (__SI_FAULT\|0) /* Broken dup of SI_USER */
		#endif /* __KERNEL__ */
		#define __FPE_DECOVF (__SI_FAULT\|9) /* decimal overflow */
		#define __FPE_DECDIV (__SI_FAULT\|10) /* decimal division by zero */
		#define __FPE_DECERR (__SI_FAULT\|11) /* packed decimal error */

arch/ia64/kernel/traps.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -349,7 +349,7 @@ handle_fpu_swa (int fp_fault, struct pt_regs *regs, unsigned long isr)
		}
		siginfo.si_signo = SIGFPE;
		siginfo.si_errno = 0;
		siginfo.si_code = __SI_FAULT; /* default code */
		siginfo.si_code = FPE_FIXME; /* default code */
		siginfo.si_addr = (void __user *) (regs->cr_iip + ia64_psr(regs)->ri);
		if (isr & 0x11) {
		siginfo.si_code = FPE_FLTINV;
		@@ -373,7 +373,7 @@ handle_fpu_swa (int fp_fault, struct pt_regs *regs, unsigned long isr)
		/* raise exception */
		siginfo.si_signo = SIGFPE;
		siginfo.si_errno = 0;
		siginfo.si_code = __SI_FAULT; /* default code */
		siginfo.si_code = FPE_FIXME; /* default code */
		siginfo.si_addr = (void __user *) (regs->cr_iip + ia64_psr(regs)->ri);
		if (isr & 0x880) {
		siginfo.si_code = FPE_FLTOVF;

Admin message