Commit 80bfc3b4 authored by David S. Miller's avatar David S. Miller
Browse files

Merge branch 'dp83867-fix-fifo-depth' 



Dan Murphy says:

====================
Fix Tx/Rx FIFO depth for DP83867

The DP83867 supports both the RGMII and SGMII modes.  The Tx and Rx FIFO depths
are configurable in these modes but may not applicable for both modes.

When the device is configured for RGMII mode the Tx FIFO depth is applicable
and for SGMII mode both Tx and Rx FIFO depth settings are applicable.  When
the driver was originally written only the RGMII device was available and there
were no standard fifo-depth DT properties.

The patchset converts the special ti,fifo-depth property to the standard
tx-fifo-depth property while still allowing the ti,fifo-depth property to be
set as to maintain backward compatibility.

In addition to this change the rx-fifo-depth property support was added and only
written when the device is configured for SGMII mode.
====================

Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parents 65e6d901 e02d1816

Documentation/devicetree/bindings/net/ti,dp83867.txt

+9 −3
Original line number Diff line number Diff line
@@ -8,8 +8,6 @@ Required properties: 
	- ti,tx-internal-delay - RGMII Transmit Clock Delay - see dt-bindings/net/ti-dp83867.h

		for applicable values. Required only if interface type is

		PHY_INTERFACE_MODE_RGMII_ID or PHY_INTERFACE_MODE_RGMII_TXID

	- ti,fifo-depth - Transmitt FIFO depth- see dt-bindings/net/ti-dp83867.h

		for applicable values



Note: If the interface type is PHY_INTERFACE_MODE_RGMII the TX/RX clock delays

      will be left at their default values, as set by the PHY's pin strapping.
@@ -42,6 +40,14 @@ Optional property: 
				    Some MACs work with differential SGMII clock.

				    See data manual for details.



	- ti,fifo-depth - Transmitt FIFO depth- see dt-bindings/net/ti-dp83867.h

		for applicable values (deprecated)



	-tx-fifo-depth - As defined in the ethernet-controller.yaml.  Values for

			 the depth can be found in dt-bindings/net/ti-dp83867.h

	-rx-fifo-depth - As defined in the ethernet-controller.yaml.  Values for

			 the depth can be found in dt-bindings/net/ti-dp83867.h



Note: ti,min-output-impedance and ti,max-output-impedance are mutually

      exclusive. When both properties are present ti,max-output-impedance

      takes precedence.
@@ -55,7 +61,7 @@ Example: 
		reg = <0>;

		ti,rx-internal-delay = <DP83867_RGMIIDCTL_2_25_NS>;

		ti,tx-internal-delay = <DP83867_RGMIIDCTL_2_75_NS>;

		ti,fifo-depth = <DP83867_PHYCR_FIFO_DEPTH_4_B_NIB>;

		tx-fifo-depth = <DP83867_PHYCR_FIFO_DEPTH_4_B_NIB>;

	};



Datasheet can be found:

drivers/net/phy/dp83867.c

+49 −13
Original line number Diff line number Diff line
@@ -93,9 +93,11 @@ 
#define DP83867_STRAP_STS2_CLK_SKEW_NONE	BIT(2)



/* PHY CTRL bits */

#define DP83867_PHYCR_FIFO_DEPTH_SHIFT		14

#define DP83867_PHYCR_TX_FIFO_DEPTH_SHIFT	14

#define DP83867_PHYCR_RX_FIFO_DEPTH_SHIFT	12

#define DP83867_PHYCR_FIFO_DEPTH_MAX		0x03

#define DP83867_PHYCR_FIFO_DEPTH_MASK		GENMASK(15, 14)

#define DP83867_PHYCR_TX_FIFO_DEPTH_MASK	GENMASK(15, 14)

#define DP83867_PHYCR_RX_FIFO_DEPTH_MASK	GENMASK(13, 12)

#define DP83867_PHYCR_RESERVED_MASK		BIT(11)



/* RGMIIDCTL bits */
@@ -131,7 +133,8 @@ enum { 
struct dp83867_private {

	u32 rx_id_delay;

	u32 tx_id_delay;

	u32 fifo_depth;

	u32 tx_fifo_depth;

	u32 rx_fifo_depth;

	int io_impedance;

	int port_mirroring;

	bool rxctrl_strap_quirk;
@@ -408,18 +411,32 @@ static int dp83867_of_init(struct phy_device *phydev) 
		dp83867->port_mirroring = DP83867_PORT_MIRROING_DIS;



	ret = of_property_read_u32(of_node, "ti,fifo-depth",

				   &dp83867->fifo_depth);

				   &dp83867->tx_fifo_depth);

	if (ret) {

		phydev_err(phydev,

			   "ti,fifo-depth property is required\n");

		return ret;

		ret = of_property_read_u32(of_node, "tx-fifo-depth",

					   &dp83867->tx_fifo_depth);

		if (ret)

			dp83867->tx_fifo_depth =

					DP83867_PHYCR_FIFO_DEPTH_4_B_NIB;

	}

	if (dp83867->fifo_depth > DP83867_PHYCR_FIFO_DEPTH_MAX) {

		phydev_err(phydev,

			   "ti,fifo-depth value %u out of range\n",

			   dp83867->fifo_depth);



	if (dp83867->tx_fifo_depth > DP83867_PHYCR_FIFO_DEPTH_MAX) {

		phydev_err(phydev, "tx-fifo-depth value %u out of range\n",

			   dp83867->tx_fifo_depth);

		return -EINVAL;

	}



	ret = of_property_read_u32(of_node, "rx-fifo-depth",

				   &dp83867->rx_fifo_depth);

	if (ret)

		dp83867->rx_fifo_depth = DP83867_PHYCR_FIFO_DEPTH_4_B_NIB;



	if (dp83867->rx_fifo_depth > DP83867_PHYCR_FIFO_DEPTH_MAX) {

		phydev_err(phydev, "rx-fifo-depth value %u out of range\n",

			   dp83867->rx_fifo_depth);

		return -EINVAL;

	}



	return 0;

}

#else
@@ -458,12 +475,31 @@ static int dp83867_config_init(struct phy_device *phydev) 
		phy_clear_bits_mmd(phydev, DP83867_DEVADDR, DP83867_CFG4,

				   BIT(7));



	if (phy_interface_is_rgmii(phydev) ||

	    phydev->interface == PHY_INTERFACE_MODE_SGMII) {

		val = phy_read(phydev, MII_DP83867_PHYCTRL);

		if (val < 0)

			return val;



		val &= ~DP83867_PHYCR_TX_FIFO_DEPTH_MASK;

		val |= (dp83867->tx_fifo_depth <<

			DP83867_PHYCR_TX_FIFO_DEPTH_SHIFT);



		if (phydev->interface == PHY_INTERFACE_MODE_SGMII) {

			val &= ~DP83867_PHYCR_RX_FIFO_DEPTH_MASK;

			val |= (dp83867->rx_fifo_depth <<

				DP83867_PHYCR_RX_FIFO_DEPTH_SHIFT);

		}



		ret = phy_write(phydev, MII_DP83867_PHYCTRL, val);

		if (ret)

			return ret;

	}



	if (phy_interface_is_rgmii(phydev)) {

		val = phy_read(phydev, MII_DP83867_PHYCTRL);

		if (val < 0)

			return val;

		val &= ~DP83867_PHYCR_FIFO_DEPTH_MASK;

		val |= (dp83867->fifo_depth << DP83867_PHYCR_FIFO_DEPTH_SHIFT);



		/* The code below checks if "port mirroring" N/A MODE4 has been

		 * enabled during power on bootstrap.

CRA Git | Maintained and supported by SUSTech CRA and CCSE