Commit 80b16c19 authored Jul 21, 2007 by Milan Broz Committed by Linus Torvalds Jul 21, 2007

dm io: fix panic on large request



Flush workqueue before releasing bioset and mopools in dm-crypt.  There can
be finished but not yet released request.

Call chain causing oops:
  run workqueue
    dec_pending
      bio_endio(...);
      	<remove device request - remove mempool>
      mempool_free(io, cc->io_pool);

This usually happens when cryptsetup create temporary
luks mapping in the beggining of crypt device activation.

When dm-core calls destructor crypt_dtr, no new request
are possible.

Signed-off-by: Milan Broz <mbroz@redhat.com>
Cc: Chuck Ebbert <cebbert@redhat.com>
Cc: Patrick McHardy <kaber@trash.net>
Acked-by: Alasdair G Kergon <agk@redhat.com>
Cc: Christophe Saout <christophe@saout.de>
Cc: <stable@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent d3fec424

drivers/md/dm-crypt.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -920,6 +920,8 @@ static void crypt_dtr(struct dm_target *ti)
		{
		struct crypt_config cc = (struct crypt_config ) ti->private;

		flush_workqueue(_kcryptd_workqueue);

		bioset_free(cc->bs);
		mempool_destroy(cc->page_pool);
		mempool_destroy(cc->io_pool);

Admin message