Commit 80970472 authored Sep 13, 2013 by Sergei Trofimovich Committed by Michal Marek Oct 23, 2013

Makefile: enable -Werror=implicit-int and -Werror=strict-prototypes by default



The common error found in forward-ported/backported patches is missing
headers.  One recent example (files and function names are mangled):

    void foo(){}
    EXPORT_SYMBOL(foo);

gave only warning

    foo.c:12345678:5: warning: function declaration isn't a prototype [-Wstrict-prototypes]
    void foo(){}
         ^

    foo.c:12345679:5: warning: data definition has no type or storage class [enabled by default]
    EXPORT_SYMBOL(foo);
    foo.c:12345679:5: warning: type defaults to 'int' in declaration of 'EXORT_SYMBOL' [-Werror=implicit-int]

Now it's a fatal error. Tested on x86_64 allyesconfig.

[akpm@linux-foundation.org: fix typos in comments]
Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Michal Marek <mmarek@suse.cz>

parent 272b98c6

Makefile

+6 −0

Original line number	Diff line number	Diff line
		@@ -659,6 +659,12 @@ KBUILD_CFLAGS += $(call cc-option,-fno-strict-overflow)
		# conserve stack if available
		KBUILD_CFLAGS += $(call cc-option,-fconserve-stack)

		# disallow errors like 'EXPORT_GPL(foo);' with missing header
		KBUILD_CFLAGS += $(call cc-option,-Werror=implicit-int)

		# require functions to have arguments in prototypes, not empty 'int foo()'
		KBUILD_CFLAGS += $(call cc-option,-Werror=strict-prototypes)

		# use the deterministic mode of AR if available
		KBUILD_ARFLAGS := $(call ar-option,D)

Admin message