Commit 8096f80a authored May 09, 2020 by Wei Yongjun Committed by Bjorn Andersson May 11, 2020

remoteproc/mediatek: fix invalid use of sizeof in scp_ipi_init()



sizeof() when applied to a pointer typed expression gives the
size of the pointer, not that of the pointed data.

Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Fixes: 63c13d61 ("remoteproc/mediatek: add SCP support for mt8183")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Link: https://lore.kernel.org/r/20200509084237.36293-1-weiyongjun1@huawei.com


Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>

parent 93bc3fee

drivers/remoteproc/mtk_scp.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -132,8 +132,8 @@ static int scp_ipi_init(struct mtk_scp *scp)
		(struct mtk_share_obj __iomem *)(scp->sram_base + recv_offset);
		scp->send_buf =
		(struct mtk_share_obj __iomem *)(scp->sram_base + send_offset);
		memset_io(scp->recv_buf, 0, sizeof(scp->recv_buf));
		memset_io(scp->send_buf, 0, sizeof(scp->send_buf));
		memset_io(scp->recv_buf, 0, sizeof(*scp->recv_buf));
		memset_io(scp->send_buf, 0, sizeof(*scp->send_buf));

		return 0;
		}

Admin message