Commit 808e657c authored Oct 29, 2013 by Michael Opdenacker Committed by Linus Walleij Nov 04, 2013

pinctrl: remove minor dead code



This removes a test whether the 'desc' variable is NULL.
This possibility has already been eliminated by the
below test earlier in the loop:

                if (desc == NULL) {
                        dev_warn(pctldev->dev,
                                 "could not get pin desc for pin %d\n",
                                 pins[i]);
                        continue;
                }

Found with Coverity: CID #1090078

Signed-off-by: Michael Opdenacker <michael.opdenacker@free-electrons.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

parent a3183c60

drivers/pinctrl/pinmux.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -505,16 +505,14 @@ void pinmux_disable_setting(struct pinctrl_setting const *setting)
		pin_free(pctldev, pins[i], NULL);
		} else {
		const char *gname;
		const char *pname;

		pname = desc ? desc->name : "non-existing";
		gname = pctlops->get_group_name(pctldev,
		setting->data.mux.group);
		dev_warn(pctldev->dev,
		"not freeing pin %d (%s) as part of "
		"deactivating group %s - it is already "
		"used for some other setting",
		pins[i], pname, gname);
		pins[i], desc->name, gname);
		}
		}

Admin message