spi: pxa2xx: Remove the shutdown callback (8089babe) · Commits · 戴 / test

It makes no sense to remove the device on shutdown. And it break things when the hardware crucial for shutdown (such as the embedded controller) is attached to the SPI bus. Signed-off-by:

Lubomir Rintel <lkundrak@v3.sk> Signed-off-by:

Mark Brown <broonie@kernel.org>

drivers/spi/spi-pxa2xx.c

+0 −9

Original line number	Diff line number	Diff line
		@@ -1764,14 +1764,6 @@ static int pxa2xx_spi_remove(struct platform_device *pdev)
		return 0;
		}

		static void pxa2xx_spi_shutdown(struct platform_device *pdev)
		{
		int status = 0;

		if ((status = pxa2xx_spi_remove(pdev)) != 0)
		dev_err(&pdev->dev, "shutdown failed with %d\n", status);
		}

		#ifdef CONFIG_PM_SLEEP
		static int pxa2xx_spi_suspend(struct device *dev)
		{
		@@ -1845,7 +1837,6 @@ static struct platform_driver driver = {
		},
		.probe = pxa2xx_spi_probe,
		.remove = pxa2xx_spi_remove,
		.shutdown = pxa2xx_spi_shutdown,
		};

		static int __init pxa2xx_spi_init(void)

Admin message