ARM: PCI: remove unused sys->hw (8084de8a) · Commits · 戴 / test

Some platforms mark their hw_pci structure as __initdata, which means it will be discarded after init time. Storing pointers to __initdata in long lived data structures is a potential source of problems, and in this case, sys->hw is unused apart from its initialization. So, lets remove this member and its initializer. Signed-off-by:

Russell King <rmk+kernel@arm.linux.org.uk>

arch/arm/include/asm/mach/pci.h

+0 −1

Original line number	Diff line number	Diff line
		@@ -45,7 +45,6 @@ struct pci_sys_data {
		u8 (swizzle)(struct pci_dev , u8 *);
		/* IRQ mapping */
		int (map_irq)(const struct pci_dev , u8, u8);
		struct hw_pci *hw;
		void private_data; / platform controller private data */
		};

arch/arm/kernel/bios32.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -424,7 +424,6 @@ static void __init pcibios_init_hw(struct hw_pci *hw)
		#ifdef CONFIG_PCI_DOMAINS
		sys->domain = hw->domain;
		#endif
		sys->hw = hw;
		sys->busnr = busnr;
		sys->swizzle = hw->swizzle;
		sys->map_irq = hw->map_irq;

Admin message