Commit 8081ad06 authored Apr 22, 2020 by Sean Christopherson Committed by Paolo Bonzini May 13, 2020

KVM: x86: Set KVM_REQ_EVENT if run is canceled with req_immediate_exit set



Re-request KVM_REQ_EVENT if vcpu_enter_guest() bails after processing
pending requests and an immediate exit was requested.  This fixes a bug
where a pending event, e.g. VMX preemption timer, is delayed and/or lost
if the exit was deferred due to something other than a higher priority
_injected_ event, e.g. due to a pending nested VM-Enter.  This bug only
affects the !injected case as kvm_x86_ops.cancel_injection() sets
KVM_REQ_EVENT to redo the injection, but that's purely serendipitous
behavior with respect to the deferred event.

Note, emulated preemption timer isn't the only event that can be
affected, it simply happens to be the only event where not re-requesting
KVM_REQ_EVENT is blatantly visible to the guest.

Fixes: f4124500 ("KVM: nVMX: Fully emulate preemption timer")
Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com>
Message-Id: <20200423022550.15113-4-sean.j.christopherson@intel.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

parent d2060bd4

arch/x86/kvm/x86.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -8519,6 +8519,8 @@ static int vcpu_enter_guest(struct kvm_vcpu *vcpu)
		return r;

		cancel_injection:
		if (req_immediate_exit)
		kvm_make_request(KVM_REQ_EVENT, vcpu);
		kvm_x86_ops.cancel_injection(vcpu);
		if (unlikely(vcpu->arch.apic_attention))
		kvm_lapic_sync_from_vapic(vcpu);

Admin message