mvpp2: remove module bugfix (807eaf99) · Commits · 戴 / test

The remove function does not destroy all BM Pools when per cpu pool is active. When reloading the mvpp2 as a module the BM Pools are still active in hardware and due to the bug have twice the size now old + new. This eventually leads to a kernel crash. v2: * add Fixes tag Fixes: ("mvpp2: percpu buffers") Signed-off-by:

Sven Auhagen <sven.auhagen@voleatech.de> Signed-off-by:

David S. Miller <davem@davemloft.net>

drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c

+5 −2

Original line number	Diff line number	Diff line
		@@ -5983,8 +5983,8 @@ static int mvpp2_remove(struct platform_device *pdev)
		{
		struct mvpp2 *priv = platform_get_drvdata(pdev);
		struct fwnode_handle *fwnode = pdev->dev.fwnode;
		int i = 0, poolnum = MVPP2_BM_POOLS_NUM;
		struct fwnode_handle *port_fwnode;
		int i = 0;

		mvpp2_dbgfs_cleanup(priv);

		@@ -5998,7 +5998,10 @@ static int mvpp2_remove(struct platform_device *pdev)

		destroy_workqueue(priv->stats_queue);

		for (i = 0; i < MVPP2_BM_POOLS_NUM; i++) {
		if (priv->percpu_pools)
		poolnum = mvpp2_get_nrxqs(priv) * 2;

		for (i = 0; i < poolnum; i++) {
		struct mvpp2_bm_pool *bm_pool = &priv->bm_pools[i];

		mvpp2_bm_pool_destroy(&pdev->dev, priv, bm_pool);

Admin message