Commit 806d3909 authored Mar 11, 2020 by Darrick J. Wong

xfs: mark extended attr corrupt when lookup-by-hash fails



In xchk_xattr_listent, we attempt to validate the extended attribute
hash structures by performing a attr lookup by (hashed) name.  If the
lookup returns ENODATA, that means that the hash information is corrupt.
The _process_error functions don't catch this, so we have to add that
explicitly.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>

parent 2e107cf8

fs/xfs/scrub/attr.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -160,6 +160,9 @@ xchk_xattr_listent(
		args.valuelen = valuelen;

		error = xfs_attr_get_ilocked(&args);
		/* ENODATA means the hash lookup failed and the attr is bad */
		if (error == -ENODATA)
		error = -EFSCORRUPTED;
		if (!xchk_fblock_process_error(sx->sc, XFS_ATTR_FORK, args.blkno,
		&error))
		goto fail_xref;

Admin message