Commit 805a8ab3 authored May 29, 2009 by Sonic Zhang Committed by David S. Miller May 29, 2009

netdev: bfin_mac: fix malformed UDP packet transmission when polling with KGDB

Writes to the DMA descriptors may sit in the internal Blackfin data buffers
and not actually be available when the DMA engine goes to fetch them. This
does not typically happen, but when dealing with short/fast packets such as
UDP and polling KGDB, this occurs much more frequently. Same goes for
heavy loads as seen by netperf tests or large scp transfers. So force the
buffers to drain with SSYNC otherwise we get random malformed packets.

Signed-off-by: Sonic Zhang <sonic.zhang@analog.com>
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Signed-off-by: Bryan Wu <cooloney@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 91a455f0

drivers/net/bfin_mac.c

+6 −0

Original line number	Diff line number	Diff line
		@@ -688,6 +688,12 @@ static int bfin_mac_hard_start_xmit(struct sk_buff *skb,
		}
		}

		/* make sure the internal data buffers in the core are drained
		* so that the DMA descriptors are completely written when the
		* DMA engine goes to fetch them below
		*/
		SSYNC();

		/* enable this packet's dma */
		current_tx_ptr->desc_a.config \|= DMAEN;

Admin message