Commit 804d057c authored Jul 30, 2020 by Colin Ian King Committed by Oded Gabbay Aug 22, 2020

habanalabs: fix incorrect check on failed workqueue create



The null check on a failed workqueue create is currently null checking
hdev->cq_wq rather than the pointer hdev->cq_wq[i] and so the test
will never be true on a failed workqueue create. Fix this by checking
hdev->cq_wq[i].

Addresses-Coverity: ("Dereference before null check")
Fixes: 5574cb21 ("habanalabs: Assign each CQ with its own work queue")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Oded Gabbay <oded.gabbay@gmail.com>
Signed-off-by: Oded Gabbay <oded.gabbay@gmail.com>

parent 58361aae

drivers/misc/habanalabs/common/device.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -288,7 +288,7 @@ static int device_early_init(struct hl_device *hdev)
		for (i = 0 ; i < hdev->asic_prop.completion_queues_count ; i++) {
		snprintf(workq_name, 32, "hl-free-jobs-%u", i);
		hdev->cq_wq[i] = create_singlethread_workqueue(workq_name);
		if (hdev->cq_wq == NULL) {
		if (hdev->cq_wq[i] == NULL) {
		dev_err(hdev->dev, "Failed to allocate CQ workqueue\n");
		rc = -ENOMEM;
		goto free_cq_wq;

Admin message