Commit 8042d6ce authored Nov 25, 2019 by Hrvoje Zeba Committed by Jens Axboe Nov 25, 2019

io_uring: remove superfluous check for sqe->off in io_accept()



This field contains a pointer to addrlen and checking to see if it's set
returns -EINVAL if the caller sets addr & addrlen pointers.

Fixes: 17f2fe35 ("io_uring: add support for IORING_OP_ACCEPT")
Signed-off-by: Hrvoje Zeba <zeba.hrvoje@gmail.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

parent 181e448d

fs/io_uring.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1965,7 +1965,7 @@ static int io_accept(struct io_kiocb req, const struct io_uring_sqe sqe,

		if (unlikely(req->ctx->flags & (IORING_SETUP_IOPOLL\|IORING_SETUP_SQPOLL)))
		return -EINVAL;
		if (sqe->ioprio \|\| sqe->off \|\| sqe->len \|\| sqe->buf_index)
		if (sqe->ioprio \|\| sqe->len \|\| sqe->buf_index)
		return -EINVAL;

		addr = (struct sockaddr __user *) (unsigned long) READ_ONCE(sqe->addr);

Admin message