Commit 803c0012 authored Mar 07, 2016 by Al Viro

ncpfs: fix a braino in OOM handling in ncp_fill_cache()



Failing to allocate an inode for child means that cache for *parent* is
incompletely populated.  So it's parent directory inode ('dir') that
needs NCPI_DIR_CACHE flag removed, *not* the child inode ('inode', which
is what we'd failed to allocate in the first place).

Fucked-up-in: commit 5e993e25 ("ncpfs: get rid of d_validate() nonsense")
Fucked-up-by: Al Viro <viro@zeniv.linux.org.uk>
Cc: stable@vger.kernel.org # v3.19
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

parent a528aca7

fs/ncpfs/dir.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -633,7 +633,7 @@ ncp_fill_cache(struct file file, struct dir_context ctx,
		d_rehash(newdent);
		} else {
		spin_lock(&dentry->d_lock);
		NCP_FINFO(inode)->flags &= ~NCPI_DIR_CACHE;
		NCP_FINFO(dir)->flags &= ~NCPI_DIR_CACHE;
		spin_unlock(&dentry->d_lock);
		}
		} else {

Admin message