Commit 8018ec08 authored by Brian Foster's avatar Brian Foster Committed by Dave Chinner
Browse files

xfs: mark all internal workqueues as freezable 



Workqueues must be explicitly set as freezable to ensure they are frozen
in the assocated part of the hibernation/suspend sequence. Freezing of
workqueues and kernel threads is important to ensure that modifications
are not made on-disk after the hibernation image has been created.
Otherwise, the in-memory state can become inconsistent with what is on
disk and eventually lead to filesystem corruption. We have reports of
free space btree corruptions that occur immediately after restore from
hibernate that suggest the xfs-eofblocks workqueue could be causing
such problems if it races with hibernation.

Mark all of the internal XFS workqueues as freezable to ensure nothing
changes on-disk once the freezer infrastructure freezes kernel threads
and creates the hibernation image.

Signed-off-by: default avatarBrian Foster <bfoster@redhat.com>
Reported-by: default avatarCarlos E. R. <carlos.e.r@opensuse.org>
Reviewed-by: default avatarDave Chinner <dchinner@redhat.com>
Signed-off-by: default avatarDave Chinner <david@fromorbit.com>
parent 52addcf9

fs/xfs/xfs_buf.c

+1 −1
Original line number Diff line number Diff line
@@ -1884,7 +1884,7 @@ xfs_buf_init(void) 
		goto out;



	xfslogd_workqueue = alloc_workqueue("xfslogd",

					WQ_MEM_RECLAIM | WQ_HIGHPRI, 1);

				WQ_MEM_RECLAIM | WQ_HIGHPRI | WQ_FREEZABLE, 1);

	if (!xfslogd_workqueue)

		goto out_free_buf_zone;

fs/xfs/xfs_mru_cache.c

+2 −1
Original line number Diff line number Diff line
@@ -304,7 +304,8 @@ _xfs_mru_cache_reap( 
int

xfs_mru_cache_init(void)

{

	xfs_mru_reap_wq = alloc_workqueue("xfs_mru_cache", WQ_MEM_RECLAIM, 1);

	xfs_mru_reap_wq = alloc_workqueue("xfs_mru_cache",

				WQ_MEM_RECLAIM|WQ_FREEZABLE, 1);

	if (!xfs_mru_reap_wq)

		return -ENOMEM;

	return 0;

fs/xfs/xfs_super.c

+8 −7
Original line number Diff line number Diff line
@@ -838,32 +838,32 @@ xfs_init_mount_workqueues( 
	struct xfs_mount	*mp)

{

	mp->m_data_workqueue = alloc_workqueue("xfs-data/%s",

			WQ_MEM_RECLAIM, 0, mp->m_fsname);

			WQ_MEM_RECLAIM|WQ_FREEZABLE, 0, mp->m_fsname);

	if (!mp->m_data_workqueue)

		goto out;



	mp->m_unwritten_workqueue = alloc_workqueue("xfs-conv/%s",

			WQ_MEM_RECLAIM, 0, mp->m_fsname);

			WQ_MEM_RECLAIM|WQ_FREEZABLE, 0, mp->m_fsname);

	if (!mp->m_unwritten_workqueue)

		goto out_destroy_data_iodone_queue;



	mp->m_cil_workqueue = alloc_workqueue("xfs-cil/%s",

			WQ_MEM_RECLAIM, 0, mp->m_fsname);

			WQ_MEM_RECLAIM|WQ_FREEZABLE, 0, mp->m_fsname);

	if (!mp->m_cil_workqueue)

		goto out_destroy_unwritten;



	mp->m_reclaim_workqueue = alloc_workqueue("xfs-reclaim/%s",

			0, 0, mp->m_fsname);

			WQ_FREEZABLE, 0, mp->m_fsname);

	if (!mp->m_reclaim_workqueue)

		goto out_destroy_cil;



	mp->m_log_workqueue = alloc_workqueue("xfs-log/%s",

			0, 0, mp->m_fsname);

			WQ_FREEZABLE, 0, mp->m_fsname);

	if (!mp->m_log_workqueue)

		goto out_destroy_reclaim;



	mp->m_eofblocks_workqueue = alloc_workqueue("xfs-eofblocks/%s",

			0, 0, mp->m_fsname);

			WQ_FREEZABLE, 0, mp->m_fsname);

	if (!mp->m_eofblocks_workqueue)

		goto out_destroy_log;
@@ -1715,7 +1715,8 @@ xfs_init_workqueues(void) 
	 * AGs in all the filesystems mounted. Hence use the default large

	 * max_active value for this workqueue.

	 */

	xfs_alloc_wq = alloc_workqueue("xfsalloc", WQ_MEM_RECLAIM, 0);

	xfs_alloc_wq = alloc_workqueue("xfsalloc",

			WQ_MEM_RECLAIM|WQ_FREEZABLE, 0);

	if (!xfs_alloc_wq)

		return -ENOMEM;

CRA Git | Maintained and supported by SUSTech CRA and CCSE