EDAC/amd64: Get rid of the ECC disabled long message (7fdfee92) · Commits · 戴 / test

This message keeps flooding dmesg on boxes where ECC is disabled or the DIMMs do not support ECC but the module gets auto-probed. What's even worse is that autoprobing happens on every CPU due to the CPU-family matching the driver does and uevent being generated for each CPU device. What is more, this message is becoming even more useless on newer systems where forcing ECC is not recommended and it should be done in the BIOS so the BIOS can do all the necessary work, i.e., just setting a bit in an MSR is not enough anymore. So get rid of it. Signed-off-by:

Borislav Petkov <bp@suse.de> Cc: Yazen Ghannam <yazen.ghannam@amd.com> Cc: linux-edac@vger.kernel.org Link: https://lkml.kernel.org/r/20191106160607.GC28380@zn.tnic

drivers/edac/amd64_edac.c

+3 −16

Original line number	Diff line number	Diff line
		@@ -3188,18 +3188,6 @@ static void restore_ecc_error_reporting(struct ecc_settings *s, u16 nid,
		amd64_warn("Error restoring NB MCGCTL settings!\n");
		}

		/*
		* EDAC requires that the BIOS have ECC enabled before
		* taking over the processing of ECC errors. A command line
		* option allows to force-enable hardware ECC later in
		* enable_ecc_error_reporting().
		*/
		static const char *ecc_msg =
		"ECC disabled in the BIOS or no ECC capability, module will not load.\n"
		" Either enable ECC checking or force module loading by setting "
		"'ecc_enable_override'.\n"
		" (Note that use of the override may cause unknown side effects.)\n";

		static bool ecc_enabled(struct amd64_pvt *pvt)
		{
		u16 nid = pvt->mc_node_id;
		@@ -3246,10 +3234,9 @@ static bool ecc_enabled(struct amd64_pvt *pvt)
		amd64_info("Node %d: DRAM ECC %s.\n",
		nid, (ecc_en ? "enabled" : "disabled"));

		if (!ecc_en \|\| !nb_mce_en) {
		amd64_info("%s", ecc_msg);
		if (!ecc_en \|\| !nb_mce_en)
		return false;
		}
		else
		return true;
		}

Admin message