Commit 7fdbaa1b authored Jun 10, 2011 by Jeff Layton Committed by Steve French Jun 13, 2011

cifs: don't allow cifs_reconnect to exit with NULL socket pointer

It's possible for the following set of events to happen:

cifsd calls cifs_reconnect which reconnects the socket. A userspace
process then calls cifs_negotiate_protocol to handle the NEGOTIATE and
gets a reply. But, while processing the reply, cifsd calls
cifs_reconnect again. Eventually the GlobalMid_Lock is dropped and the
reply from the earlier NEGOTIATE completes and the tcpStatus is set to
CifsGood. cifs_reconnect then goes through and closes the socket and sets the
pointer to zero, but because the status is now CifsGood, the new socket
is not created and cifs_reconnect exits with the socket pointer set to
NULL.

Fix this by only setting the tcpStatus to CifsGood if the tcpStatus is
CifsNeedNegotiate, and by making sure that generic_ip_connect is always
called at least once in cifs_reconnect.

Note that this is not a perfect fix for this issue. It's still possible
that the NEGOTIATE reply is handled after the socket has been closed and
reconnected. In that case, the socket state will look correct but it no
NEGOTIATE was performed on it be for the wrong socket. In that situation
though the server should just shut down the socket on the next attempted
send, rather than causing the oops that occurs today.

Cc: <stable@kernel.org> # .38.x: fd88ce93: [CIFS] cifs: clarify the meaning of tcpStatus == CifsGood
Reported-and-Tested-by: Ben Greear <greearb@candelatech.com>
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Steve French <sfrench@us.ibm.com>

parent cd51875d

fs/cifs/connect.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -152,7 +152,7 @@ cifs_reconnect(struct TCP_Server_Info *server)
		mid_entry->callback(mid_entry);
		}

		while (server->tcpStatus == CifsNeedReconnect) {
		do {
		try_to_freeze();

		/* we should try only the port we connected to before */
		@@ -167,7 +167,7 @@ cifs_reconnect(struct TCP_Server_Info *server)
		server->tcpStatus = CifsNeedNegotiate;
		spin_unlock(&GlobalMid_Lock);
		}
		}
		} while (server->tcpStatus == CifsNeedReconnect);

		return rc;
		}
		@@ -3374,7 +3374,7 @@ int cifs_negotiate_protocol(unsigned int xid, struct cifs_ses *ses)
		}
		if (rc == 0) {
		spin_lock(&GlobalMid_Lock);
		if (server->tcpStatus != CifsExiting)
		if (server->tcpStatus == CifsNeedNegotiate)
		server->tcpStatus = CifsGood;
		else
		rc = -EHOSTDOWN;

Admin message