Commit 7fce2cf6 authored Jul 12, 2005 by Chen, Kenneth W Committed by James Bottomley Jul 14, 2005

[SCSI] Redundant this_count check in sd_init_command()



I was going over the scsi I/O submit path, when sd_init_command
construct the scsi command, this_count is already checked in the
previous else if clause.  Why does it need to check it again in
the last else block?

Patch to delete the spurious check.

Signed-off-by: Ken Chen <kenneth.w.chen@intel.com>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>

parent 0f34e3f5

drivers/scsi/sd.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -373,9 +373,6 @@ static int sd_init_command(struct scsi_cmnd * SCpnt)
		SCpnt->cmnd[7] = (unsigned char) (this_count >> 8) & 0xff;
		SCpnt->cmnd[8] = (unsigned char) this_count & 0xff;
		} else {
		if (this_count > 0xff)
		this_count = 0xff;

		SCpnt->cmnd[1] \|= (unsigned char) ((block >> 16) & 0x1f);
		SCpnt->cmnd[2] = (unsigned char) ((block >> 8) & 0xff);
		SCpnt->cmnd[3] = (unsigned char) block & 0xff;

Admin message