Commit 7fcd5330 authored Jan 18, 2006 by Al Viro Committed by Linus Torvalds Jan 18, 2006

[PATCH] nfsd4_lock() returns bogus values to clients



missing nfserrno() in default case of a switch by return value of
posix_lock_file(); as the result we send negative host-endian to clients that
expect positive network-endian, preferably mentioned in RFC...  BTW, that case
is not impossible - posix_lock_file() can return -ENOLCK and we do not handle
that one explicitly.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Neil Brown <neilb@suse.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent de1ae286

fs/nfsd/nfs4state.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -2761,7 +2761,10 @@ nfsd4_lock(struct svc_rqst rqstp, struct svc_fh current_fh, struct nfsd4_lock
		goto conflicting_lock;
		case (EDEADLK):
		status = nfserr_deadlock;
		dprintk("NFSD: nfsd4_lock: posix_lock_file() failed! status %d\n",status);
		goto out;
		default:
		status = nfserrno(status);
		dprintk("NFSD: nfsd4_lock: posix_lock_file() failed! status %d\n",status);
		goto out;
		}

Admin message