Commit 7fcd011a authored Nov 18, 2019 by zhengbin Committed by Greg Kroah-Hartman Nov 18, 2019

staging: rtl8723bs: remove set but not used variable 'pHalData', 'pregistrypriv'

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/staging/rtl8723bs/hal/sdio_halinit.c: In function sdio_AggSettingRxUpdate:
drivers/staging/rtl8723bs/hal/sdio_halinit.c:578:23: warning: variable pHalData set but not used [-Wunused-but-set-variable]
drivers/staging/rtl8723bs/hal/sdio_halinit.c: In function rtl8723bs_hal_init:
drivers/staging/rtl8723bs/hal/sdio_halinit.c:734:24: warning: variable pregistrypriv set but not used [-Wunused-but-set-variable]

They are introduced by commit 554c0a3a ("staging:
Add rtl8723bs sdio wifi driver"), but never used, so remove them.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
Link: https://lore.kernel.org/r/1574063156-68155-2-git-send-email-zhengbin13@huawei.com

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 04254066

drivers/staging/rtl8723bs/hal/sdio_halinit.c

+0 −5

Original line number	Diff line number	Diff line
		@@ -570,14 +570,11 @@ static void HalRxAggr8723BSdio(struct adapter *padapter)

		static void sdio_AggSettingRxUpdate(struct adapter *padapter)
		{
		struct hal_com_data *pHalData;
		u8 valueDMA;
		u8 valueRxAggCtrl = 0;
		u8 aggBurstNum = 3; /* 0:1, 1:2, 2:3, 3:4 */
		u8 aggBurstSize = 0; /* 0:1K, 1:512Byte, 2:256Byte... */

		pHalData = GET_HAL_DATA(padapter);

		valueDMA = rtw_read8(padapter, REG_TRXDMA_CTRL);
		valueDMA \|= RXDMA_AGG_EN;
		rtw_write8(padapter, REG_TRXDMA_CTRL, valueDMA);
		@@ -713,13 +710,11 @@ static u32 rtl8723bs_hal_init(struct adapter *padapter)
		s32 ret;
		struct hal_com_data *pHalData;
		struct pwrctrl_priv *pwrctrlpriv;
		struct registry_priv *pregistrypriv;
		u32 NavUpper = WiFiNavUpperUs;
		u8 u1bTmp;

		pHalData = GET_HAL_DATA(padapter);
		pwrctrlpriv = adapter_to_pwrctl(padapter);
		pregistrypriv = &padapter->registrypriv;

		if (
		adapter_to_pwrctl(padapter)->bips_processing == true &&

Admin message